Uninstall wants to delete whole view

Created on 3 May 2024, 8 months ago

Updated 6 May 2024, 8 months ago

Problem/Motivation

Attempting to uninstall views_ical, it wants to delete any views that included an ical display. It should not delete the entire view since there can be other displays in the view that have nothing to do with ical.

Steps to reproduce

1. Install views_ical.
2. Create a view with a content type block.
3. Create an iCal display in the same view and set the path, then save.
4. Attempt to uninstall and observe the module wants to delete the whole view. Optionally delete the ical view display first, such that ical is no longer used by the view, and observe that the module still wants to delete the entire view.

Proposed resolution

Change uninstaller to not delete entire views.

If this is intended behavior, which it shouldn't be, then it should be made explicitly clear in usage instructions and readme that a NEW VIEW should be made solely for using this module. Using an existing view and adding an iCal display to it will risk destroying the entire view on uninstall.

🐛 Bug report

Status

Active

Component

User interface

Created by

🇺🇸United States j_s

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @j_s
Comment 8 months ago →
🇺🇸United States bburg Washington D.C.
I suppose I'm not surprised that it deletes the view if it has a dependency on the module. I suppose this might be an issue for any module that provides a Views display plugin. This may be more of a core views issue than this module though. These issues seem similar, though not quite the same:

🐛 Config entities implementing EntityWithPluginCollectionInterface should ask the plugins to react when their dependencies are removed Needs work
#3229138: When a view display is deleted, the dependencies list is not updated properly →
Comment 8 months ago →
🇺🇸United States j_s
Ah that does look like the same sort of issue with dependency list likely not updating. Added a comment in #3229138. Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024