- First commit to issue fork.
- @ranjit1032002 opened merge request.
- Status changed to Needs review
almost 2 years ago 7:43am 19 May 2023 - 🇮🇳India Ranjit1032002
The condition !empty($row->draggableviews_structure_parent) will return true if the property is not empty, which is the opposite of what you want.
created MR!23 for the issue mentioned, please review.
Thank you. - 🇪🇸Spain jlecinaj
Couldn't reproduce the issue with last version.
Version used: 2.1.3
Steps to reproduce in case it still happens.
- 🇨🇦Canada iStryker
ChatGPT
The
empty()
function already checks for null, false, empty strings, empty arrays, and zero values, so there's no need to check for false and empty separately.So it looks like we can just simplify this.
-
istryker →
committed aadede78 on 2.1.x
Issue #3354600 by ranjit1032002, istryker: Fix undefined property...
-
istryker →
committed aadede78 on 2.1.x
Automatically closed - issue fixed for 2 weeks with no activity.