- 🇬🇧United Kingdom stefank
Hi @yashmalviya ,
As this is mainly ok, I would suggest to change the issue title and description to cover all files in the module/project for Drupal coding standards or you change only the relevant code which the title is suggesting.
Thanks - Status changed to Needs review
over 1 year ago 6:37am 13 June 2023 - 🇮🇳India Ashutosh Ahirwal India
Hi I have changed the title of this issue and also performed the issue fixes which was rised by below command.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/image_field_captionProviding patch with phpcs-issue-fixes.
- Status changed to RTBC
over 1 year ago 6:58am 13 June 2023 - 🇵🇭Philippines paraderojether
Hi @Ashutosh Ahirwal
I reviewed patch 4, applied it against Image Field Caption 8.x-1.2, and confirmed it fixes the errors/warnings that is reported by phpcs.
I added screenshots for reference.
Thank You. -
iStryker →
committed 14109786 on 1.0.x authored by
Ashutosh Ahirwal →
Issue #3333247 by yashmalviya, Ashutosh Ahirwal, iStryker: Fix the...
-
iStryker →
committed 14109786 on 1.0.x authored by
Ashutosh Ahirwal →
- Status changed to Fixed
10 months ago 10:06pm 16 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.