🇬🇧United Kingdom @stefank

stefank → made their first commit to this issue’s fork.

stefank → made their first commit to this issue’s fork.

stefank → created an issue.

stefank → created an issue.

stefank → made their first commit to this issue’s fork.

stefank → made their first commit to this issue’s fork.

stefank → changed the visibility of the branch 3469693-drupal-11-compatibility to active.

stefank → changed the visibility of the branch 3469693-drupal-11-compatibility to hidden.

stefank → created an issue.

stefank → changed the visibility of the branch 3326881-robots.txt-file-not to active.

stefank → changed the visibility of the branch 3326881-robots.txt-file-not to hidden.

stefank → made their first commit to this issue’s fork.

stefank → made their first commit to this issue’s fork.

Hi all,

Really sorry to reopen the issue, but this seems to be easy fixable in the Gin theme, and it seems that the overflow: auto; in the .gin-table-scroll-wrapper is not really needed. Correct me if wrong.
Creating a MR, just to be able for the maintainers to consider the change.

stefank → made their first commit to this issue’s fork.

Hi all,

Maybe this issue is related to https://www.drupal.org/project/image_field_caption/issues/3306138 🐛 Multiple Image Fields lost caption after save Needs review . Can you please try with the attached MR patch?

Updated D10 core version support.

Hi @iancawthorne,

Attaching new patch, which should apply cleanly using composer.

Hi all,

Attaching a patch for D10 as well, in case anyone also needs it. Should apply cleanly using composer.

@iancawthorne

should be for 1.0.x. Applied cleanly while testing.

Hi all,

Here is a different approach. Instead of using CKEditor5 ContextualBalloon, I have taken the step to use Drupal dialog, same as it was on CKeditor4. this way, the user has a textarea field and with combination with https://www.drupal.org/project/ckeditor_tippy/issues/3316775 ✨ Html support Needs review the user has full potential to create formatted tooltip, without needing the enter HTML tags manually.
Feel free to clean up the code and make improvements. Let's keep the ball rolling.

Right, here is another go, as the previous patches still left some warnings in some conditions. this one should prevent it.

Sorry, here is anothe patch, which doesnt have double accessCheck.

Hi all,

Here is a reroll for the patch for 2.0.0 branch.

Hi all,

In some cases the views can be embeded into page as blocks, so the submit buttons will have different selectors. For example it will add the views id and random id to the edit-reset. For this, we should check if the data-drupal-selector contains the edit-reset, rather than is equal.
Attaching patch for that.

Hi,

Attaching a patch to be able to save the score config data into webform element.

Attaching patch.

stefank → created an issue.

Attaching a new patch, which should apply now.
For me, as we allow HTML support, then the HTML format in the same patch makes sense. But, I will leave it for discussion and let the module maintainers to decide.

stefank → made their first commit to this issue’s fork.

For me, when I was saving a translation, the value in the source entity has been lost. The image field is part of paragraph. Tracked it down to a sql query to get the caption with revision_id condition.
@HeavyStoneHead FYI, all of the values are stored in DB, so its worth to check if this is your case as well.
This is the first step for fixing the code, but overall it has fixed the issue for me.

stefank → made their first commit to this issue’s fork.

Hi @yashmalviya ,

As this is mainly ok, I would suggest to change the issue title and description to cover all files in the module/project for Drupal coding standards or you change only the relevant code which the title is suggesting.
Thanks

Attaching patch.

stefank → created an issue.

Hi all,

Tested on 9.4.5 and patch in #31 still applies cleanly and works as expected, prevent the error message "Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it". Also, I have tested using the new approach from #37, but still getting the same issue.

Tested on site which is multilingual, and the detection is done using url (Domain url). When adding for example a menu item and the domain url is set for example in DE and the select list field for language is set for example in FR, then Im getting the error message. The menu is added, but the screen just displays the error, which is confusing for the end user.
Trusted hosts patterns in setting.php is set as "*".

As the above patch does the job, I though that it would be useful to have a text_format instead of textarea, where we can also choose the default text format.