- Issue created by @gaspounet
- First commit to issue fork.
- Status changed to Needs work
9 months ago 8:19pm 3 June 2024 - π¨π¦Canada mandclu
This is a strange one. I can't reproduce the cited error, and having put your suggested fix into an MR, phpcs throws an error on the declared use of ViewExecutable as unused. I also notice that the error statement referred to draggableviews_views_pre_render(), which isn't present in the draggableviews.module file in 2.1.4, and it says the error is on line 276, where the file in 2.1.4 ends on line 270. Do you have a patch applied to the 2.1.4 release?
- π«π·France gaspounet
Strange indeed! I had a former patch ( issue 3316975 π Contextual Link throws RouteNotFoundException: Route "view.this" does not exist Needs review ) that I removed from my composer.json file because it seems to have been merged in the 2.1.4 release
- πΊπΈUnited States fholub13
#5 was my exact experience as well. I had the aforementioned former patch installed (3316975-15) on a client site and was experiencing the error detailed in this issue. Removing the patch, deleting the module directory, and running a new composer install remedied the error.
- πΊπΈUnited States reddy_l
I am also getting the same error with 2.1.4 version of module. Attached patch fixed the issue
- π¬π§United Kingdom jacobupal Leeds
Thanks @gaspounet
Incidentally,
composer reinstall drupal/draggableviews
also achieves the same thing, i.e. deleting the directory before installing the module with patches etc. - Status changed to Fixed
4 months ago 12:47pm 23 October 2024 - π¨π¦Canada iStryker
I am going to mark this as fixed because of https://git.drupalcode.org/project/draggableviews/-/commit/d1a4a588dceae...
It adds the "Use" of viewExecutable and adds
function draggableviews_views_pre_render(ViewExecutable $view) {
Oddly, I checked and did not see draggalbeviews_views_pre_render in any of the last tag versions (2.0.2->2.1.4). This makes me think everyone uses a patched version (some people hinted at it). Going from the patch version to 2.1.4 will remain broken. Going from the patched version to the next release (2.1.5, maybe) will not be an issue.
Automatically closed - issue fixed for 2 weeks with no activity.