- π¨π¦Canada iStryker
Re-roll. Applies cleanly to 8.x-3.18 and 8.x-3.x
- Status changed to Needs review
almost 2 years ago 1:11am 9 June 2023 - last update
almost 2 years ago 6 pass, 2 fail - πΊπΈUnited States jrb Raleigh-Durham Area, NC, USA
The patch in #16 did not work for us. We got this error with each project that it checked:
Message TypeError: Argument 1 passed to Drupal\upgrade_status\TwigRecursiveIterator::__construct() must be an instance of Drupal\Core\Extension\Extension, string given, called in /app/web/modules/contrib/upgrade_status/src/TwigDeprecationAnalyzer.php on line 62 in Drupal\upgrade_status\TwigRecursiveIterator->__construct() (line 20 of /app/web/modules/contrib/upgrade_status/src/TwigRecursiveIterator.php)
This new patch fixes that error in
TwigDeprecationAnalyzer
andLibraryDeprecationAnalyzer
. The last submitted patch, 17: 3146667-17.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
10 months ago 3:33pm 12 June 2024 - Status changed to Needs review
10 months ago 4:02pm 12 June 2024 - ππΊHungary GΓ‘bor Hojtsy Hungary
How is this reviewed and tested, what did you do to review and test?
- πΊπΈUnited States scott_earnest
I was able to get the patch to apply but got an error trying to scan the modules that newly appeared"
There are two calls to
RecursiveDirectoryIterator
that were updated in the patch to supply the classDrupal\Core\Extension\Extension
. However this PHP function takes a string as the first argument:https://www.php.net/manual/en/recursivedirectoryiterator.construct.php
Attaching updated patch.
- πΊπΈUnited States scott_earnest
Testing Steps
Prior to patching, on a site using an install profile, create a custom module within the profile as such:
docroot
-profiles
--my_custom_profile
---modules
----custom
-----my_custom_moduleNotice that the custom module does NOT appear on the Upgrade Status report
Apply the patch
Notice the module will appear in the report as such:
My Module (in my_custom_profile profile) (my_custom_module)
Click the checkbox next to the module -> click scan -> verify scans successfully, an will supply upgrade recommendations