Explore splitting the coverage of profiles into their subextensions

Created on 5 June 2020, almost 5 years ago
Updated 2 February 2023, about 2 years ago

Problem/Motivation

I believe there was an issue for this, but I cannot find it, so submitting is now. Several people raised that install profiles / distributions are displayed as one is a problem. When you are building your own profile, if its not a Drupal.org project, listing the components as their own would make more sense.

Proposed resolution

Either consider profiles if they are custom, and display as individual projects or consider a UI solution for displaying install profile components as individual items.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

✨ Feature request
Status

Needs work

Version

3.0

Component

Code

Created by

πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada iStryker

    Re-roll. Applies cleanly to 8.x-3.18 and 8.x-3.x

  • Status changed to Needs review almost 2 years ago
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    6 pass, 2 fail
  • πŸ‡ΊπŸ‡ΈUnited States jrb Raleigh-Durham Area, NC, USA

    The patch in #16 did not work for us. We got this error with each project that it checked:

    Message TypeError: Argument 1 passed to Drupal\upgrade_status\TwigRecursiveIterator::__construct() must be an instance of Drupal\Core\Extension\Extension, string given, called in /app/web/modules/contrib/upgrade_status/src/TwigDeprecationAnalyzer.php on line 62 in Drupal\upgrade_status\TwigRecursiveIterator->__construct() (line 20 of /app/web/modules/contrib/upgrade_status/src/TwigRecursiveIterator.php)

    This new patch fixes that error in TwigDeprecationAnalyzer and LibraryDeprecationAnalyzer.

  • The last submitted patch, 17: 3146667-17.patch, failed testing. View results β†’
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Status changed to RTBC 10 months ago
  • πŸ‡¨πŸ‡¦Canada iStryker

    Re-roll for 4.x

  • Status changed to Needs review 10 months ago
  • πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

    How is this reviewed and tested, what did you do to review and test?

  • πŸ‡ΊπŸ‡ΈUnited States scott_earnest

    I was able to get the patch to apply but got an error trying to scan the modules that newly appeared"

    There are two calls to RecursiveDirectoryIterator that were updated in the patch to supply the class Drupal\Core\Extension\Extension. However this PHP function takes a string as the first argument:

    https://www.php.net/manual/en/recursivedirectoryiterator.construct.php

    Attaching updated patch.

  • πŸ‡ΊπŸ‡ΈUnited States scott_earnest

    Testing Steps

    Prior to patching, on a site using an install profile, create a custom module within the profile as such:
    docroot
    -profiles
    --my_custom_profile
    ---modules
    ----custom
    -----my_custom_module

    Notice that the custom module does NOT appear on the Upgrade Status report

    Apply the patch

    Notice the module will appear in the report as such:

    My Module (in my_custom_profile profile) (my_custom_module)

    Click the checkbox next to the module -> click scan -> verify scans successfully, an will supply upgrade recommendations

Production build 0.71.5 2024