πŸ‡¦πŸ‡ͺUnited Arab Emirates @mudasirweb

Account created on 30 August 2013, over 11 years ago
#

Recent comments

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Hi @sandip, I understand your point β€” we're addressing one issue here and creating a separate ticket for the responsive issue. However, the goal isn’t just to get the MR merged, but to find the right solution.

If we look at MR568, it actually resolves both issues, and I genuinely wonder why we can't consider merging it. I've attached a screenshot after applying MR568 for reference:

https://www.drupal.org/files/issues/2025-04-15/MR-568.png β†’

I believe the community should take a moment to review both MRs and make a decision that best addresses the problem comprehensively.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Hi @piridium, I tested MR608 and I’m still seeing the Remove button overflowing the border, and the image along with the drag handle are misaligned.

It looks like the issue stems from some internal gaps and margins within the image widget itself. I don’t believe align-self: center will resolve this.

That said, it no longer interferes with the use of multivalued fields, so I think MR568 is a good solution for now.

Screenshot after applying MR608
https://www.drupal.org/files/issues/2025-04-15/MR608.png β†’

Screenshot after applying #3
https://www.drupal.org/files/issues/2025-04-15/%233-patch.png β†’

Screenshot after Applying MR568
https://www.drupal.org/files/issues/2025-04-15/MR-568.png β†’

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Hi all I attempted to replicate the issue, and it still occurred even after applying #3. I then applied the provided PR, and it was applied cleanly without any errors. After applying the PR, the multivalued image field overlap issue was successfully resolved, along with the issues mentioned in comment #17. The multivalued image fields no longer interfere with the use of multivalued fields.

Result #3 Patch
https://www.drupal.org/files/issues/2025-04-15/%233-patch.png β†’

Result after PR 3493765-widget-for-multivalued
https://www.drupal.org/files/issues/2025-04-15/Issue-fork-3493765-widget... β†’

Can someone please take a look.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Ensure the "X" button is properly positioned for both single-value and multi-value fields.

Desktop

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

mudasirweb β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Moved image title to top in-order to maintain integrity with the single image field.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Fixed pipeline failure.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Fixed mobile and iPad resolutions. Also aligned remove button and image name.
Please review.

Before:

After

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Noticed a couple of issues:

1. The layout breaks on mobile and iPad resolutions.
2. The "Remove" button is too close to the title and alt fields.
3. It would make more sense to display the image name below the image.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb
πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb
πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb
πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

Oh, I forgot to enable the title and alt fields, which is why they didn't appear for me.

I have pushed a fix for the field alignment now.

πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb
πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb
πŸ‡¦πŸ‡ͺUnited Arab Emirates mudasirweb

mudasirweb β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024