I have added a template to the custom block and set the category of the block to system. I was also able to successfully test the functionality including the new template. I added a MR for the new block plugin implementation.
Alright, looks good to me. I merged the MR.
I created a new pull request to add the hook implementation for the help module.
I reviewed the MR and merged it.
simhag β made their first commit to this issueβs fork.
simhag β created an issue.
simhag β created an issue.
simhag β created an issue.
simhag β created an issue.
simhag β created an issue.
simhag β created an issue.
I reviewed the PR8 and can confirm that the messages are now in the untranslated version.
RTBC +1
I would suggest to use a more generic title, because other modules might also make use of the logo file
I reviewed the PR392 and can confirm that the logo is now available in the module. Im not sure if the logo.png is also needed elsewhere.
I have reviewed the PR and can confirm that the message now includes the label. (See screenshot).
Even if I agree that an ID of the view might be more meaningful, the label is definitely an enrichment for the user from my point of view.
RTBC +1
simonbitmade β created an issue.