Contrib.social

Incorrect Font Awesome icon used for tel: links

Open on Drupal.org →
Created on 26 November 2024, 3 months ago

Problem

The icon used for tel: links is incorrect - it is using the external link icon.

In extlink.js around line 513 we have the following code:

Drupal.theme.extlink_fa_tel = function (drupalSettings, iconPlacement) {
    return `<span class="${drupalSettings.data.extlink.extFaLinkClasses}" data-extlink-placement="${iconPlacement}"></span>`;
  };

This should be:

Drupal.theme.extlink_fa_tel = function (drupalSettings, iconPlacement) {
    return `<span class="${drupalSettings.data.extlink.extFaTelClasses}" data-extlink-placement="${iconPlacement}"></span>`;
  };

Steps to reproduce

  1. Set `Use Font Awesome icons instead of images.` to true
  2. Define the `Font Awesome icon Classes` (or leave as default)
  3. Add a tel: link to an existing page (and save/publish)
  4. See that instead of the telephone icon we get the external link icon instead
🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

awearring

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024