Deleted menus are not removed from content type config

Followed the steps and tried the same version (10.1.x-dev) to reproduce the issue, but it's working as expected.

Maybe here we can also tackle the empty third party setting

Clarified IS as it’s in the .yml config which I’m guessing was not clear. It is definitely happening.

Thanks, @pameeela, yes that point was not clear.

Didn't see a patch or open MR to review?

eashika → closed merge request !3478

eashika → reopened merge request !3478

Left a comment on the MR.

Also will require test coverage.

dcam → changed the visibility of the branch 11.x to hidden.

dcam → changed the visibility of the branch 10.1.x to hidden.

dcam → changed the visibility of the branch 3337882-deleted-menus-are to hidden.

The first MR took the wrong approach, which was removing the settings in the menu delete form submission step. But this would have left the settings in the event that a menu was deleted by some other means. That MR needed to be closed anyway since it was for a D10 branch. But the code for doing the setting removal was still fundamentally good even though it was put in the wrong place. So I copied it to a hook_ENTITY_TYPE_delete() implementation and used it as a starting point. Then I added a Kernel test.

I just realized that I messed up and removed the check for the parent setting being set to a specific link. I'll fix it later.

Hi, I've verified and tested MR! 11946 and applied the patch successfully on 11. x-dev Version: The changes are working as expected.

1. Create a New Menu Type: Go to /admin/structure/Menus/Add Menus, Give it a name (eg : Test Menu), Save.
2. Add the Menu to a Content Type: Go to Structure > Content types > Basic page > Manage fields>Edit >Menu settings, Under "Available menus", check your new Test Menu, Save
3. Delete the Menu: Go back to Structure > Menus, delete the Test Menu.
4. Check if Config is Still There: Go to Configuration > Development > Configuration Synchronization, Click Export, Click Single item, Choose Content type, Select Basic page, Click Export
5. Now open the exported YAML and check

Testing Result:
After you delete the menu, it will be removed from this YAML export automatically. Hence, the changes are working as expected.

Attaching the screenshot for reference.

Hence, moving to RTBC!
Thanks