- Issue created by @pemson18
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
prem suthar โ made their first commit to this issueโs fork.
- @prem-suthar opened merge request.
- ๐ฎ๐ฑIsrael jsacksick
How is this working without changing the services.yml? I know we have autowiring now, but the arguments are explicitly specified for the subscriber.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@jsacksick yes you are right if we explicitly specified for the subscriber arguments then we need to add this .
i got confused by this one i think it already exits.commerce_order.order_receipt_mail: class: Drupal\commerce_order\Mail\OrderReceiptMail arguments: ['@entity_type.manager', '@commerce.mail_handler', '@commerce_order.order_total_summary', '@token']
Now i have added the third argument @token to the arguments array.
- ๐ฎ๐ฑIsrael jsacksick
Wait this is not the right place for this... This should be fixed from the OrderReceiptMail service which already does token replacements for the subject. We already have the token service available there.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@jsacksick I added it in the OrderReceiptSubscriber (commerce_order.order_receipt_subscriber), not in the OrderReceiptMail service.
- ๐ฎ๐ฑIsrael jsacksick
@prem suthar: Yes I know, that is exactly my point, it needs to be in the OrderReceiptMail service?