Radioactivity not set when creating nodes in code

Unfortunately it is only by the field widget. If the widget wasn't displayed, the Radioactivity entity won't be created.

My team also has this problem.

I'm working on this.

I was able to keep all the necessary changes inside the RadioactivityReferenceItem field type class. I added a functional test to prove that the changes I have done do not break the functionality provided by the radioactivity_reference field widget. Maybe on the next major version bump, the Radioactivity entity specific parts could be cleaned up from the widget's class.

RadioactivityReferenceFieldTypeTest tests quite lot cases:

• Create entities with or without energy.
• How the field type behaves if it is attached to a translatable entity.
• What happens if the entity is translatable, but the Radioactivity field is not translatable

Imho this is ready for review.

I also attach a patch file which only contains the actual fix. Please keep in mind that this patch file represents the fix in MR-6 at b62ff2f1

The MRs and the patch I added are very wrong. The field shouldn’t make any assumptions based on the target ID value!

Okay, now it should be fine!

Fix-only patch attached.

Attaching the most recent fix-only patches.

The last submitted patch, 12: radioactivity-move_entity_management_from_field_widget_to_entity_level-3325229-11--complete.diff, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tr → changed the visibility of the branch 3325229-test-only to hidden.

prem suthar → made their first commit to this issue’s fork.

@tr raised the mr as per the #15 so please review.

tr → changed the visibility of the branch 4.0.x to hidden.

tr → changed the visibility of the branch 3325229-api-create to hidden.

Thanks for helping out!

This is my first time looking at this patch. In general I'm in favor of this change, and I agree that the entities should be managed in the field type, not in the widget. I especially like all the new tests - that really helps to define the expected behavior of this code and ensure that we don't break the expected behavior with future changes to the codebase.

But now that all the module tests for 4.1.x branch are passing, I want to make sure we don't introduce new test failures with this MR. So what I would like to see here is to have all the test warnings/errors/failures fixed in the MR before I do a detailed review and commit this. Can you work on the MR to fix the problems with the tests?