Contrib.social

Coding standard issues

Open on Drupal.org →
Created on 11 October 2024, 6 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml .

FILE: .../web/modules/custom/total_control/src/Routing/RouteSubscriber.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RoutingEvents.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/AdministerMenus.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
119 | WARNING | [ ] Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
220 | WARNING | [ ] Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/AdministerPanelPages.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/CreateContent.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/ContentOverview.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/AdministerContentTypes.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Block/AdministerTaxonomy.php
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/src/Plugin/Derivative/TotalControlMenuLink.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/total_control/tests/src/FunctionalJavascript/TotalControlDashboardPageCheckTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml .

Proposed resolution

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Comment 6 months ago →
    🇵🇪Peru alyaj2a
  • Comment 6 months ago →
    🇵🇪Peru alyaj2a
  • Comment 6 months ago →
    🇮🇳India divyansh.gupta Jaipur
  • Merge request !4Resolve #3480265 "Coding standard issues" → (Open) created by divyansh.gupta
  • Comment 6 months ago →
    🇮🇳India divyansh.gupta Jaipur

    Solved PHP_CodeSniffer errors by using dependency injections for menu.

  • Comment 6 months ago →
    🇵🇭Philippines clarkssquared

    Hi

    I applied MR !4 and checked the PHPCS and there is only one PHPCS warning left in the module

    ➜  total_control git:(3.0.x) curl https://git.drupalcode.org/project/total_control/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11520    0 11520    0     0  21209      0 --:--:-- --:--:-- --:--:-- 21532
patching file 'src/Plugin/Block/AdministerContentTypes.php'
patching file 'src/Plugin/Block/AdministerMenus.php'
patching file 'src/Plugin/Block/AdministerPanelPages.php'
patching file 'src/Plugin/Block/AdministerTaxonomy.php'
patching file 'src/Plugin/Block/ContentOverview.php'
patching file 'src/Plugin/Block/CreateContent.php'
patching file 'src/Plugin/Derivative/TotalControlMenuLink.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'tests/src/FunctionalJavascript/TotalControlDashboardPageCheckTest.php'
➜  total_control git:(3.0.x) ✗ ..
➜  contrib git:(2.1.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml total_control 

FILE: ...ksubing-subing/Projects/drupal-issues/drupal-contrib/web/modules/contrib/total_control/css/theme/total-control.theme.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------

Time: 734ms; Memory: 10MB

➜  contrib git:(2.1.x) ✗
  • Comment 6 months ago →
    🇮🇳India divyansh.gupta Jaipur

    Hello @clarkssquared,
    The error you mentioned is already mentioned in .phpcs.xml file to exclude this file and it was also not mentioned in issue summary.
    <exclude-pattern>css/theme/total-control.theme.css</exclude-pattern>.
    So still should i remove this error or leave it.
    Also I found similar issue where it is told that it is not a issue or bug:
    📌 File appears to be minified and cannot be processed Closed: works as designed .
    Also if you think that remaining errors mentioned in the issue summary are solved so can you please move the state of the issue to needs review, or if you think i should solve this error than please let me know so that i can try to remove this error.

  • Comment 5 months ago →
    🇵🇭Philippines clarkssquared

    Hi @ divyansh.gupta

    Got it, I will move the status to needs review so that other users can check also, RTBC +1 from me.

    Thanks

  • Comment 5 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno → made their first commit to this issue’s fork.

  • Merge request !5Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
  • Pipeline finished with Success
    5 months ago
    Total: 230s
    #322413
  • Comment 5 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno → changed the visibility of the branch 3480265-gitlab-ci-reports to hidden.

  • Comment 5 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment 4 months ago →
    🇮🇳India kulpratap2002

    I have reviewed the issue and verified that all PHPCS issues have been resolved. The GitLab CI pipeline is passing with no phpcs errors. Based on this, I am moving the issue to RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024