Contrib.social
Created on 14 December 2024, 4 months ago

Problem/Motivation

FILE: drupal/web/modules/contrib/metatag_search_gov/metatag_search_gov.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

FILE: drupal/web/modules/contrib/metatag_search_gov/src/Plugin/SearchCustomBase.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
7 | ERROR | Doc comment is empty
12 | ERROR | Doc comment is empty
---------------------------------------------------------------------------------------------------

Time: 71ms; Memory: 12MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India radheymkumar Jaipur, Rajasthan, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @radheymkumar
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡³India radheymkumar Jaipur, Rajasthan, India

    I have fixed phpcs issue and attched patch file
    Review patch and apply

  • Comment 4 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi radheymkumar

    I applied patch #2 and I confirmed that it fixes all the PHPCS issues

    āžœ  metatag_search_gov git:(main) āœ— curl https://www.drupal.org/files/issues/2024-12-14/metatag_search_gov-3493966.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1789  100  1789    0     0   3975      0 --:--:-- --:--:-- --:--:--  4047
patching file README.md
patching file metatag_search_gov.info.yml
patching file 'src/Plugin/SearchCustomBase.php'
āžœ  metatag_search_gov git:(main) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml metatag_search_gov 
āžœ  contrib git:(main) āœ—

    RTBC +1 from me, retaining the status to needs review for others.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024