Contrib.social
Created on 31 January 2025, 23 days ago

Problem/Motivation

FILE: /var/www/html/Growth/modules/contrib/pie_chart/src/Plugin/Block/NodePieChartBlock.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
59 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/Growth/modules/contrib/pie_chart/src/Controller/NodePieChartController.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
59 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/Growth/modules/contrib/pie_chart/js/pie_chart.js
--------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
48 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
92 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
99 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
144 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
151 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
163 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Gajendersingh1999

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Gajendersingh1999
  • Comment 23 days ago ā†’
    šŸ‡®šŸ‡³India Gajendersingh1999
  • Comment 21 days ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    hi gajendersingh1999,

    I applied your patch #2 but I can still se some phpcs warnings:

    āžœ  pie_chart git:(main) āœ— curl https://www.drupal.org/files/issues/2025-01-31/issueFixed_3503609_2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13198  100 13198    0     0  27464      0 --:--:-- --:--:-- --:--:-- 27961
patching file 'js/pie_chart.js'
patching file 'src/Controller/NodePieChartController.php'
patching file 'src/Plugin/Block/NodePieChartBlock.php'
āžœ  pie_chart git:(main) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pie_chart 

FILE: ...pal-issues/drupal-project/web/modules/contrib/pie_chart/pie_chart.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 255ms; Memory: 10MB

āžœ  contrib git:(main) āœ—

    Also, can you create a merge request for your patch? so that it will be convenient on maintainer's end, thanks.

  • First commit to issue fork.
  • Merge request !1Resolved phpcs issue ā†’ (Merged) created by Unnamed author
  • Comment 21 days ago ā†’
    šŸ‡®šŸ‡³India vishalydv
  • Comment 7 days ago ā†’
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024