- Issue created by @kinyein
- šØš“Colombia kinyein
Hi, I made a merge request to fix the coding standards issue in this module, I hope it can be reviewed soon.
- šµšPhilippines paraderojether
Hi kinyein,
I reviewed MR!7, and confirmed it passed the phpcs using Gitlab CI. However there are still phpcs issues reported using the PHP_CodeSniffer.
ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee FILE: ...rs/jetherparadero/Q1/q1contributions/web/modules/contrib/recombee/src/Form/SettingsForm.php ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------- 44 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 45 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 50 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 51 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 96 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 102 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 118 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------- FILE: ...Q1/q1contributions/web/modules/contrib/recombee/src/Plugin/Block/RecombeePublicScenario.php ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 131 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------- Time: 165ms; Memory: 10MB
Command used:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee
Kindly check and advise, please.
Thank you. - First commit to issue fork.
- š®š³India abhiyanshu
Fixed the remaining coding standard issues.
Please refer to the attached screenshot for more clarity. Thank you. - šµšPhilippines paraderojether
Hi
I reviewed MR!7 again and confirmed it passed the phpcs using Gitlab CI and PHP_CodeSniffer.
ā recombee git:(2.0.x) curl https://git.drupalcode.org/project/recombee/-/merge_requests/7.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4790 0 4790 0 0 10822 0 --:--:-- --:--:-- --:--:-- 10961 patching file 'js/recombee.properties.js' patching file 'js/recombee.public_scenario.js' patching file 'js/recombee.tracker.js' patching file 'src/Form/SettingsForm.php' patching file 'src/Plugin/Block/RecombeePublicScenario.php' ā recombee git:(2.0.x) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee ā contrib git:(main) ā
Moving this to RTBC.
Thank you.