Fix the issues reported by phpcs

vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml themes/drupal8_custom_theme/ PHP Warning: Module "fileinfo" is already loaded in Unknown on line 0 PHP Warning: Module "gd" is already loaded in Unknown on line 0 PHP Warning: Module "gettext" is already loaded in Unknown on line 0 FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/drupal8_custom_theme.libraries.yml ------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 48 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/css/custom-style.css ------------------------------------------------------------------------------------------------ FOUND 179 ERRORS AFFECTING 153 LINES ------------------------------------------------------------------------------------------------ 3 | ERROR | [x] Whitespace found at end of line 12 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 23 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 23 | ERROR | [x] Opening brace should be the last content on the line 23 | ERROR | [x] Closing brace of class definition must be on new line 25 | ERROR | [x] Multiple selectors should each be on a single line 25 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 25 | ERROR | [x] Opening brace should be the last content on the line 25 | ERROR | [x] Each style definition must be on a line by itself 25 | ERROR | [x] Closing brace of class definition must be on new line 27 | ERROR | [x] Multiple selectors should each be on a single line 27 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 27 | ERROR | [x] Opening brace should be the last content on the line 27 | ERROR | [x] Each style definition must be on a line by itself 27 | ERROR | [x] Closing brace of class definition must be on new line 29 | ERROR | [x] Multiple selectors should each be on a single line 29 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 29 | ERROR | [x] Opening brace should be the last content on the line 29 | ERROR | [x] Each style definition must be on a line by itself 29 | ERROR | [x] Closing brace of class definition must be on new line 31 | ERROR | [x] Multiple selectors should each be on a single line 31 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 31 | ERROR | [x] Opening brace should be the last content on the line 31 | ERROR | [x] Each style definition must be on a line by itself 31 | ERROR | [x] Closing brace of class definition must be on new line 33 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 33 | ERROR | [x] Opening brace should be the last content on the line 33 | ERROR | [x] Closing brace of class definition must be on new line 35 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 35 | ERROR | [x] Opening brace should be the last content on the line 35 | ERROR | [x] Closing brace of class definition must be on new line 37 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 42 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 46 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 51 | ERROR | [x] Multiple selectors should each be on a single line 55 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 59 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 69 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 73 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 84 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 90 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 97 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 102 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 106 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 113 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 120 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 128 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 134 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 140 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 151 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 164 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 169 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 174 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 178 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 193 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 200 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 210 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 230 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 234 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 244 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 250 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 252 | ERROR | [x] CSS colours must be defined in lowercase; expected #4d4f4a but found #4D4F4A 261 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 267 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 273 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 280 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 285 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 291 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 295 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 300 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 305 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 313 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 317 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 321 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 330 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 343 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 347 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 354 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 360 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 364 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 370 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 374 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 380 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 386 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 403 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 407 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 408 | ERROR | [x] CSS colours must be defined in lowercase; expected #29c5f6 but found #29C5F6 411 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 415 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 416 | ERROR | [x] CSS colours must be defined in lowercase; expected #c61118 but found #C61118 419 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 420 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff6d00 but found #FF6D00 423 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 429 | ERROR | [x] Multiple selectors should each be on a single line 429 | ERROR | [x] Multiple selectors should each be on a single line 429 | ERROR | [x] Multiple selectors should each be on a single line 429 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 434 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 438 | ERROR | [x] Whitespace found at end of line 439 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 450 | ERROR | [x] Whitespace found at end of line 451 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 458 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 464 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 485 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 489 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 493 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 498 | ERROR | [x] Whitespace found at end of line 499 | ERROR | [x] Whitespace found at end of line 500 | ERROR | [x] Whitespace found at end of line 501 | ERROR | [x] Whitespace found at end of line 502 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 507 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 518 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 519 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 519 | ERROR | [x] Whitespace found at end of line 525 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 526 | ERROR | [x] CSS colours must be defined in lowercase; expected #eef0f7 but found #EEF0F7 529 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 534 | ERROR | [x] CSS colours must be defined in lowercase; expected #dcdcdc but found #DCDCDC 535 | ERROR | [x] CSS colours must be defined in lowercase; expected #efefef but found #EFEFEF 536 | ERROR | [x] Whitespace found at end of line 538 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 544 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 553 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 558 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 562 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 568 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 572 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 576 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 582 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 587 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 592 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 607 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 612 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 621 | ERROR | [x] Whitespace found at end of line 622 | ERROR | [x] Whitespace found at end of line 623 | ERROR | [x] Whitespace found at end of line 624 | ERROR | [x] Whitespace found at end of line 625 | ERROR | [x] Whitespace found at end of line 639 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 647 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 659 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 663 | ERROR | [x] Whitespace found at end of line 672 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 673 | ERROR | [x] CSS colours must be defined in lowercase; expected #66cbff but found #66CBFF 689 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF 693 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 699 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 704 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 709 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 715 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 719 | ERROR | [x] CSS colours must be defined in lowercase; expected #f5f5f5 but found #F5F5F5 722 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 727 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 733 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 742 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 746 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 752 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 760 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 764 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 770 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 781 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 789 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 796 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 802 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 806 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 813 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 819 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 823 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 827 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 833 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 849 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 855 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 859 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 865 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 871 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 875 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 881 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 179 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/css/custom-media.css ------------------------------------------------------------------------------------------ FOUND 41 ERRORS AFFECTING 39 LINES ------------------------------------------------------------------------------------------ 3 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 7 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 11 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 16 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 20 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 24 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 31 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 35 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 41 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 48 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 55 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 63 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 67 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 71 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 102 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 106 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 110 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 125 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 129 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 133 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 137 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 143 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 143 | ERROR | [x] Whitespace found at end of line 147 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 147 | ERROR | [x] Whitespace found at end of line 151 | ERROR | [x] Whitespace found at end of line 152 | ERROR | [x] Whitespace found at end of line 153 | ERROR | [x] Multiple selectors should each be on a single line 154 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF 158 | ERROR | [x] Whitespace found at end of line 159 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 163 | ERROR | [x] Whitespace found at end of line 164 | ERROR | [x] Whitespace found at end of line 165 | ERROR | [x] Whitespace found at end of line 171 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 175 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 179 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 183 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 189 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 191 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 196 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 41 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------ FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/css/font-awesome.css ---------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ---------------------------------------------------------------------------------- 121 | ERROR | Style definitions must end with a semicolon 127 | ERROR | Style definitions must end with a semicolon 133 | ERROR | Style definitions must end with a semicolon 139 | ERROR | Style definitions must end with a semicolon 145 | ERROR | Style definitions must end with a semicolon ---------------------------------------------------------------------------------- FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/css/base.css ----------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------- 121 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 367 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/drupal8_custom_theme.breakpoints.yml -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 18 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /home/gai/drupal-git/drupal/themes/drupal8_custom_theme/drupal8_custom_theme.theme ----------------------------------------------------------------------------------------------------------------------------------- FOUND 77 ERRORS AND 13 WARNINGS AFFECTING 66 LINES ----------------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Doc comment short description must end with a full stop 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 20 | ERROR | [x] There must be no blank lines after the function comment 29 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 41 | ERROR | [x] Use "elseif" in place of "else if" 44 | ERROR | [x] Use "elseif" in place of "else if" 44 | ERROR | [x] Expected 1 space after IF keyword; 0 found 56 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 92 | ERROR | [x] No space found before comment text; expected "// To get the current URL" but found "//To get the current URL" 92 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 93 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 96 | ERROR | [x] Whitespace found at end of line 97 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 99 | ERROR | [x] Expected one space after the comma, 0 found 111 | ERROR | [x] There should be no white space after an opening "{" 111 | ERROR | [x] Comments may not appear after statements 118 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 119 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 123 | ERROR | [x] Expected 1 blank line after function; 2 found 130 | ERROR | [x] Short array syntax must be used to define arrays 132 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Expected one space after the comma, 0 found 138 | ERROR | [x] Whitespace found at end of line 144 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Concat operator must be surrounded by a single space 157 | ERROR | [x] Whitespace found at end of line 158 | ERROR | [x] No space found before comment text; expected "// Social Icon Link" but found "//Social Icon Link" 158 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 159 | ERROR | [x] Short array syntax must be used to define arrays 165 | ERROR | [x] Short array syntax must be used to define arrays 171 | ERROR | [x] Short array syntax must be used to define arrays 176 | ERROR | [x] Short array syntax must be used to define arrays 181 | ERROR | [x] Short array syntax must be used to define arrays 186 | ERROR | [x] Short array syntax must be used to define arrays 191 | ERROR | [x] Short array syntax must be used to define arrays 197 | ERROR | [x] No space found before comment text; expected "// Show/Hide credit" but found "//Show/Hide credit" 197 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 198 | ERROR | [x] Short array syntax must be used to define arrays 204 | ERROR | [x] Short array syntax must be used to define arrays 210 | ERROR | [x] Short array syntax must be used to define arrays 216 | ERROR | [x] Short array syntax must be used to define arrays 222 | ERROR | [x] Short array syntax must be used to define arrays 228 | ERROR | [x] Short array syntax must be used to define arrays 233 | ERROR | [x] Short array syntax must be used to define arrays 235 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 235 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 235 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Short array syntax must be used to define arrays 241 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 241 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 241 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Concat operator must be surrounded by a single space 242 | ERROR | [x] Concat operator must be surrounded by a single space 242 | ERROR | [x] Expected one space after the comma, 0 found 245 | ERROR | [x] Short array syntax must be used to define arrays 247 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 247 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 247 | ERROR | [x] Concat operator must be surrounded by a single space 247 | ERROR | [x] Concat operator must be surrounded by a single space 248 | ERROR | [x] Expected one space after the comma, 0 found 250 | ERROR | [x] Short array syntax must be used to define arrays 252 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 252 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 252 | ERROR | [x] Concat operator must be surrounded by a single space 252 | ERROR | [x] Concat operator must be surrounded by a single space 253 | ERROR | [x] Expected one space after the comma, 0 found 255 | ERROR | [x] Short array syntax must be used to define arrays 257 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 257 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 257 | ERROR | [x] Concat operator must be surrounded by a single space 257 | ERROR | [x] Concat operator must be surrounded by a single space 258 | ERROR | [x] Expected one space after the comma, 0 found 262 | ERROR | [x] Concat operator must be surrounded by a single space 262 | ERROR | [x] Expected one space after the comma, 0 found 263 | ERROR | [x] Expected 1 space after IF keyword; 0 found 263 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 274 | ERROR | [x] Whitespace found at end of line 275 | ERROR | [x] Whitespace found at end of line 281 | ERROR | [x] Expected 1 space before opening brace; found 0 282 | ERROR | [x] Expected 1 space after IF keyword; 0 found 282 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 283 | ERROR | [x] Short array syntax must be used to define arrays 285 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 287 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 80 MARKED SNIFF VIOLATIONS AUTOMATICALLY -----------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @Akshay kashyap
Comment over 1 year ago →
🇮🇳India Akshay kashyap
Comment over 1 year ago →
🇮🇳India Akshay kashyap
Comment over 1 year ago →
🇮🇳India Akshay kashyap
I have created a Patch to fix the Drupal coding standard issue reported by phpcs. Please review it,
Status changed to Needs review over 1 year ago9:41am 31 July 2023
Comment over 1 year ago →
🇮🇳India Akshay kashyap
Issue was unassigned.
Comment 11 months ago →
🇷🇺Russia zniki.ru
Comment 5 months ago →
🇮🇳India riddhi.addweb
I have tried to apply the patch but it is failing.
Please check the screenshots for the same.
Comment 5 months ago →
🇵🇭Philippines cleavinjosh
Hi,

I provided a patch for the phpcs issues.

Please review, thank you.
Status changed to Needs work 5 months ago7:47am 30 July 2024
Comment 5 months ago →
🇮🇳India abhiyanshu
@cleavinjosh, I have reviewed and can confirm that the patch provided in #8 is still not working as expected. Moving it to "Needs Work" for further refinement. Thanks for your efforts!
Please refer to the attached screenshot for more clarity.
Merge request !11Issue #3147076 by Project Update Bot, zymphonies-sales-team, zymphonies-team,... → (Open) created by abhiyanshu
Comment 5 months ago →
🇮🇳India abhiyanshu
Resolved all the issues reported by PHPCS. There are just a few remaining warnings, primarily related to lines exceeding 80 characters and the min.js file.
Status changed to RTBC 3 months ago10:51am 12 September 2024

Comment 3 months ago →

🇵🇭Philippines cleavinjosh

Hi @abhiyanshu,

Thank you for providing an MR. I applied MR!11, it was applied smoothly and fixed all the phpcs issues.

➜  drupal8_custom_theme git:(8.x-1.x) curl https://git.drupalcode.org/project/drupal8_custom_theme/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   99k    0   99k    0     0   245k      0 --:--:-- --:--:-- --:--:--  245k
patching file css/base.css
patching file css/custom-media.css
patching file css/custom-style.css
patching file css/font-awesome.css
patching file drupal8_custom_theme.breakpoints.yml
patching file drupal8_custom_theme.info.yml
patching file drupal8_custom_theme.libraries.yml
patching file drupal8_custom_theme.theme
patching file includes/bootstrap/js/bootstrap.js
patching file js/custom.js
patching file templates/layout/page.html.twig
➜  drupal8_custom_theme git:(8.x-1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml drupal8_custom_theme
➜  contrib git:(main) ✗

I am not encountering any issue/warning related to lines exceeding 80 characters.

For the min.js files, please see comment #3 and 4 here 🐛 File appears to be minified and cannot be processed Closed: works as designed .

Changing the status to RTBC.

Thank you.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Merge Requests

!11Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Merge Requests

!11Fix the issues reported by phpcsOpen

Comments & Activities

!11Fix the issues reported by phpcs
Open