Fix issues reported by PHPCS

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml glisseo/ FILE: /var/www/web/themes/contrib/glisseo/glisseo.theme ----------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------- 43 | ERROR | [x] Parameter $element has null default value, but is not marked as nullable. 43 | ERROR | [x] Parameter $modifiers has null default value, but is not marked as nullable. 166 | ERROR | [x] Doc comment long description must end with a full stop 179 | ERROR | [x] Doc comment long description must end with a full stop 191 | ERROR | [x] Doc comment long description must end with a full stop 244 | ERROR | [x] Doc comment long description must end with a full stop ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/theme-settings.php ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 9 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES ---------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 97 characters 11 | WARNING | Line exceeds 80 characters; contains 94 characters 12 | WARNING | Line exceeds 80 characters; contains 100 characters 16 | WARNING | Line exceeds 80 characters; contains 365 characters 30 | WARNING | Line exceeds 80 characters; contains 148 characters 40 | WARNING | Line exceeds 80 characters; contains 103 characters 51 | WARNING | Line exceeds 80 characters; contains 220 characters 55 | WARNING | Line exceeds 80 characters; contains 209 characters 59 | WARNING | Line exceeds 80 characters; contains 202 characters 61 | WARNING | Line exceeds 80 characters; contains 84 characters 62 | WARNING | Line exceeds 80 characters; contains 127 characters 68 | WARNING | Line exceeds 80 characters; contains 121 characters 90 | WARNING | Line exceeds 80 characters; contains 85 characters 104 | WARNING | Line exceeds 80 characters; contains 272 characters ---------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/assets/css/04-components/ui/links.css --------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 1 LINE --------------------------------------------------------------------------------------- 5 | ERROR | [x] Opening brace should be the last content on the line 5 | ERROR | [ ] Class definition is empty 5 | ERROR | [x] Closing brace of class definition must be on new line --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/assets/css/01-generic/grid.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 4 | ERROR | Style definitions must end with a semicolon -------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/assets/css/01-generic/colors.css ---------------------------------------------------------------------------------- FOUND 10 ERRORS AFFECTING 10 LINES ---------------------------------------------------------------------------------- 4 | ERROR | [ ] Style definitions must end with a semicolon 6 | ERROR | [ ] Style definitions must end with a semicolon 7 | ERROR | [x] Blank lines are not allowed in class definitions 12 | ERROR | [x] Blank lines are not allowed in class definitions 18 | ERROR | [x] Blank lines are not allowed in class definitions 23 | ERROR | [x] Blank lines are not allowed in class definitions 26 | ERROR | [x] Blank lines are not allowed in class definitions 33 | ERROR | [x] Blank lines are not allowed in class definitions 38 | ERROR | [x] Blank lines are not allowed in class definitions 43 | ERROR | [x] Blank lines are not allowed in class definitions ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/assets/css/02-elements/typography.css --------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------- 14 | ERROR | [x] Blank lines are not allowed in class definitions 17 | ERROR | [x] Blank lines are not allowed in class definitions 19 | ERROR | [x] Blank lines are not allowed in class definitions --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/assets/css/02-elements/fieldset.css ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 16 | ERROR | Style definitions must end with a semicolon ------------------------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/STARTER.info.yml.txt ---------------------------------------------------------------------- FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES ---------------------------------------------------------------------- 6 | WARNING | Line exceeds 80 characters; contains 85 characters 57 | WARNING | Line exceeds 80 characters; contains 82 characters 59 | WARNING | Line exceeds 80 characters; contains 89 characters 61 | WARNING | Line exceeds 80 characters; contains 85 characters 68 | WARNING | Line exceeds 80 characters; contains 87 characters 70 | WARNING | Line exceeds 80 characters; contains 85 characters 72 | WARNING | Line exceeds 80 characters; contains 82 characters 73 | WARNING | Line exceeds 80 characters; contains 83 characters 74 | WARNING | Line exceeds 80 characters; contains 91 characters 75 | WARNING | Line exceeds 80 characters; contains 95 characters ---------------------------------------------------------------------- FILE: /var/www/web/themes/contrib/glisseo/STARTER/templates/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 4 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 393ms; Memory: 12MB

Comments & Activities

Issue created by @abhiyanshu
First commit to issue fork.
Comment about 1 month ago →
🇮🇳India GGH
PHPCS issues fixed
Comment 24 days ago →
🇷🇺Russia niklan Russia, Perm
Hi, can you please create a MR for the patch changes, so I can provide a review? There are clearly issues with STARTER.info.yml changes. In most cases, they are definitely wrong, and the paths are truncated at 80 characters, which is incorrect. This is actually not a .txt file; it's a YAML template that should not be treated like a TXT file, so the 80-character hard limit doesn't apply here. It just breaks things.
Merge request !2Issue #3508656: Fix issues reported by PHPCS → (Open) created by Unnamed author
Comment 23 days ago →
🇮🇳India GGH
MR Raised

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!2Fix issues reported by PHPCS
Open

Comments & Activities

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!2Fix issues reported by PHPCSOpen

Comments & Activities

!2Fix issues reported by PHPCS
Open