- Issue created by @abhiyanshu
- First commit to issue fork.
It would be great to address the below minor PHPCS issues :
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/storychief/
FILE: /var/www/web/modules/contrib/storychief/storychief.api.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
40 | ERROR | [x] Opening brace should be on the same line as the declaration
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
55 | WARNING | Line exceeds 80 characters; contains 85 characters
59 | WARNING | Line exceeds 80 characters; contains 91 characters
----------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/Plugin/FieldHandlerType/MetatagFieldHandlerType.php
-----------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 2 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
6 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Expected 1 space after IF keyword; 0 found
19 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
30 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Expected 1 blank line after function; 0 found
34 | ERROR | [x] Expected 1 newline at end of file; 2 found
34 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/Plugin/StoryChiefFieldHandler/SlugStoryChiefFieldHandler.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
48 | WARNING | [x] 'TODO: unused path_auto_prefix configuration atm.' should match the format '@todo Fix problem X here.'
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/Plugin/StoryChiefFieldHandler/SeoStoryChiefFieldHandler.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
12 | WARNING | [x] 'TODO: kill this monstrosity. Saving SEO fields should be done migrated to' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/Plugin/StoryChiefFieldHandler/CategoriesStoryChiefFieldHandler.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | [x] 'TODO: migrate legacy field ID category to categories.' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/Controller/StoryChiefWebhookController.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/EventSubscribers/StoryChiefRemoteCallPublishEventSubscriber.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/storychief/src/EventSubscribers/StoryChiefRemoteCallEventSubscriberBase.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactory.
90 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
Time: 763ms; Memory: 14MB
composer require 'drupal/storychief:^3.0'phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/storychief/
Fix the PHPCS issues.
Active
3.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.