It would be great to address the below minor PHPCS issues :
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_translation_unified_form/
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/README.txt
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
-----------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 89 characters
7 | WARNING | Line exceeds 80 characters; contains 303 characters
10 | WARNING | Line exceeds 80 characters; contains 142 characters
17 | WARNING | Line exceeds 80 characters; contains 121 characters
22 | WARNING | Line exceeds 80 characters; contains 144 characters
31 | WARNING | Line exceeds 80 characters; contains 210 characters
35 | WARNING | Line exceeds 80 characters; contains 175 characters
39 | WARNING | Line exceeds 80 characters; contains 122 characters
40 | WARNING | Line exceeds 80 characters; contains 357 characters
45 | WARNING | Line exceeds 80 characters; contains 103 characters
47 | WARNING | Line exceeds 80 characters; contains 154 characters
80 | WARNING | Line exceeds 80 characters; contains 104 characters
-----------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/entity_translation_unified_form.theme.inc
------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
34 | ERROR | [x] Short array syntax must be used to define arrays
36 | WARNING | [ ] Only string literals should be passed to t() where possible
37 | ERROR | [x] Use null coalesce operator instead of ternary operator.
42 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
45 | ERROR | [x] Short array syntax must be used to define arrays
47 | WARNING | [ ] Only string literals should be passed to t() where possible
48 | ERROR | [x] Use null coalesce operator instead of ternary operator.
49 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: ...b/modules/contrib/entity_translation_unified_form/src/Plugin/EntityTranslationUnifiedFormMode/EntityTranslationUnifiedFormInlineMode.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | Missing short description in doc comment
16 | ERROR | Doc comment is empty
23 | ERROR | Doc comment is empty
30 | ERROR | Doc comment is empty
57 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
57 | WARNING | Only string literals should be passed to t() where possible
60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
60 | WARNING | Only string literals should be passed to t() where possible
70 | ERROR | Parameter $suffix is not described in comment
87 | ERROR | The array declaration extends to column 240 (the limit is 120). The array content should be split up over multiple lines
113 | WARNING | Line exceeds 80 characters; contains 102 characters
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: ...b/modules/contrib/entity_translation_unified_form/src/Plugin/EntityTranslationUnifiedFormMode/EntityTranslationUnifiedFormTabbedMode.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | Missing short description in doc comment
15 | ERROR | Doc comment is empty
24 | WARNING | Empty return statement not required here
27 | ERROR | Doc comment is empty
39 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/src/EntityTranslationUnifiedFormModeInterface.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Missing interface doc comment
6 | ERROR | [x] No space found before comment text; expected "// public function validateDependencies" but found "//public function
| | validateDependencies"
6 | ERROR | [x] Inline comments must start with a capital letter
6 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
7 | ERROR | [x] You must use "/**" style comments for a function comment
7 | ERROR | [x] Expected 1 blank line after function; 0 found
8 | ERROR | [x] Missing function doc comment
8 | ERROR | [x] Expected 1 blank line after function; 0 found
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line after function; 0 found
10 | ERROR | [x] The closing brace for the interface must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/src/EtufHelper.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
62 | ERROR | Doc comment is empty
72 | ERROR | Doc comment is empty
-------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/src/EntityTranslationUnifiedFormModePluginManager.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
9 | ERROR | Doc comment is empty
------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/entity_translation_unified_form.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AND 45 WARNINGS AFFECTING 62 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [ ] Missing short description in doc comment
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\content_translation\BundleTranslationSettingsInterface.
16 | WARNING | [x] Unused use statement
18 | WARNING | [ ] All constants defined by a module must be prefixed with the module's name, expected
| | "ENTITY_TRANSLATION_UNIFIED_FORM_ENTITY_TRANSLATION_ENABLED" but found "ENTITY_TRANSLATION_ENABLED"
18 | WARNING | [ ] Global constants should not be used, move it to a class or interface
26 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
136 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
181 | ERROR | [ ] No key specified for array entry; first entry specifies key
207 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
218 | WARNING | [ ] Line exceeds 80 characters; contains 136 characters
420 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
458 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
473 | WARNING | [ ] Unused variable $entity_type.
500 | ERROR | [ ] No key specified for array entry; first entry specifies key
517 | ERROR | [ ] No key specified for array entry; first entry specifies key
535 | ERROR | [ ] No key specified for array entry; first entry specifies key
555 | ERROR | [ ] No key specified for array entry; first entry specifies key
631 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
637 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
684 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
693 | WARNING | [ ] Unused variable $field_name.
767 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
768 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
793 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
794 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
840 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
841 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
942 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
970 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
1004 | WARNING | [ ] Unused variable $langcode.
1022 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
1023 | WARNING | [ ] Unused variable $action.
1025 | WARNING | [ ] Unused variable $action.
1044 | WARNING | [ ] Unused variable $outer_key.
1060 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
1065 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
1093 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
1109 | WARNING | [ ] There must be no blank line following an inline comment
1115 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
1162 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
1163 | WARNING | [ ] Unused variable $action.
1165 | WARNING | [ ] Unused variable $action.
1196 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
1215 | WARNING | [ ] Unused variable $outer_key.
1238 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
1243 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
1271 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
1287 | WARNING | [ ] There must be no blank line following an inline comment
1311 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
1323 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
1340 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
1342 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
1343 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
1345 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "_custom_shutdown_menu" but
| | expected "entity_translation_unified_form__custom_shutdown_menu"
1396 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
1400 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
1403 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
1407 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
1408 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
1410 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "_custom_shutdown" but expected
| | "entity_translation_unified_form__custom_shutdown"
1465 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "etuf_latest_revision" but
| | expected "entity_translation_unified_form_etuf_latest_revision"
1514 | ERROR | [x] Additional blank lines found at end of doc comment
1515 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found
| | "entity_translation_unified_page_submit_save_only" but expected
| | "entity_translation_unified_form_entity_translation_unified_page_submit_save_only"
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/css/ten-one-sbs-claro.css
--------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
77 | ERROR | [x] Expected 1 newline at end of file; 2 found
78 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/css/ten-one-inline-claro.css
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/entity_translation_unified_form/entity_translation_unified_form.services.yml
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
Time: 943ms; Memory: 22MB
Run the command,
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_translation_unified_form/
Fix the PHPCS issues.
Active
2.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
Hi @ggh, thanks, had a quick look, it's looking pretty good, but there's some function name changes that make me a bit nervous.
Has any manual testing been done on this merge request?