Fix issues reported by PHPCS

Created on 25 February 2025, 4 days ago

Problem/Motivation

It would be great to address the below minor PHPCS issues :

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml colonel/

FILE: /var/www/web/themes/contrib/colonel/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
  4 | WARNING | Line exceeds 80 characters; contains 164 characters
 12 | WARNING | Line exceeds 80 characters; contains 268 characters
 13 | WARNING | Line exceeds 80 characters; contains 111 characters
 34 | WARNING | Line exceeds 80 characters; contains 173 characters
 36 | WARNING | Line exceeds 80 characters; contains 86 characters
 39 | WARNING | Line exceeds 80 characters; contains 106 characters
 61 | WARNING | Line exceeds 80 characters; contains 209 characters
 62 | WARNING | Line exceeds 80 characters; contains 150 characters
 74 | WARNING | Line exceeds 80 characters; contains 242 characters
 75 | WARNING | Line exceeds 80 characters; contains 128 characters
----------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/colonel/colonel.breakpoints.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/colonel/css/classy/components/indented.css
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/colonel/css/classy/components/progress.css
----------------------------------------------------------------------------------
FOUND 24 ERRORS AFFECTING 12 LINES
----------------------------------------------------------------------------------
 28 | ERROR | [ ] Style definition is empty
 28 | ERROR | [x] Expected 1 space after colon in style definition; newline found
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [ ] No style definition found on line; check for missing colon
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 30 | ERROR | [ ] No style definition found on line; check for missing colon
 31 | ERROR | [ ] Style definition is empty
 31 | ERROR | [x] Expected 1 space after colon in style definition; newline found
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [ ] No style definition found on line; check for missing colon
 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [ ] No style definition found on line; check for missing colon
 57 | ERROR | [x] Opening brace should be the last content on the line
 57 | ERROR | [x] Closing brace of class definition must be on new line
 58 | ERROR | [x] Opening brace should be the last content on the line
 58 | ERROR | [x] Closing brace of class definition must be on new line
 62 | ERROR | [x] Opening brace should be the last content on the line
 62 | ERROR | [x] Closing brace of class definition must be on new line
 63 | ERROR | [x] Opening brace should be the last content on the line
 63 | ERROR | [x] Closing brace of class definition must be on new line
 67 | ERROR | [x] Opening brace should be the last content on the line
 67 | ERROR | [x] Closing brace of class definition must be on new line
 68 | ERROR | [x] Opening brace should be the last content on the line
 68 | ERROR | [x] Closing brace of class definition must be on new line
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: /var/www/web/themes/contrib/colonel/subcolonel/README.md
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 232ms; Memory: 10MB

Steps to reproduce

  • Install the theme, composer require 'drupal/colonel:^2.2'
  • Run the command,

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml colonel/

Proposed resolution

Fix the PHPCS issues.

📌 Task
Status

Active

Version

2.2

Component

Code

Created by

🇮🇳India abhiyanshu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024