It would be great to address the below minor PHPCS issues :
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml site_settings/
FILE: ...s/contrib/site_settings/tests/modules/site_settings_sample_data/config/install/language.content_settings.site_setting_entity.test_plain_text.yml
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
17 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/tests/modules/site_settings_sample_data/site_settings_sample_data.routing.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/tests/modules/site_settings_sample_data/site_settings_sample_data.install
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
152 | WARNING | Redeclaration of global variable $base_url as global variable.
--------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/tests/src/Functional/SiteSettingsFlattenedLoaderTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\BrowserTestBase.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/tests/src/Functional/SiteSettingsFullLoaderTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\BrowserTestBase.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/README.md
-------------------------------------------------------------------------
FOUND 1 ERROR AND 12 WARNINGS AFFECTING 13 LINES
-------------------------------------------------------------------------
44 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
56 | WARNING | [ ] Line exceeds 80 characters; contains 168 characters
59 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
62 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters
80 | WARNING | [ ] Line exceeds 80 characters; contains 313 characters
82 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
83 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
94 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
103 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
104 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
110 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
117 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
146 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------
FILE: /var/www/web/modules/contrib/site_settings/css/navigation_icon.css
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------
Time: 2.58 secs; Memory: 18MB
composer require 'drupal/site_settings:^2.0'phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml site_settings/
Fix the PHPCS issues.
Active
2.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
Hi @ggh
Please create the MR for this issue
@see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
Thanks for the contribution however pipeline seems all green according to https://git.drupalcode.org/project/site_settings/-/pipelines