Merge with the main module

Hi Eric,
Thank you.
yeah we can combine them. It might as well be part of the main module for ease of use :)

There's an small issue with transparent images, I'd like to fix before that.

How do you want to handle the merge?
Replace your current js implementation or add mine as a separate formatter?

I would replace the current js implementation. It seems more comfortable and modern.

Hey @woldtwerk - Erik put me in place as a maintainer to help him with the module and I just thought what you guys already talked about. Maybe we could get this done?

Sure we can do it.
I had some minor issues I would change beforehand.
Also I would refactor a little to be more drupal compliant.

What's the best approach to go further?
Do I create an issue in the main module to be able to create an issue fork or will you give me push access to a branch?

Either way would be fine for me :) We should go for a 3.1 version anyways with this addition. I opened a 3.1.x branch for a potential fork - It might be the best to start that way so I can give you a review :)

@woldtwerk I just started working on this - I will follow Eriks suggestion and replace the JS implementation with yours. There is actually a lot under the hood that will change. I'd like to give you credits for the code I borrow, so please feel free to put yourself in an MR as a contributor/maintainer to the readme or something :)

@woldtwerk You can check out the 4.x version of image_sizes if you want. I replaced the image_sizes JS implementation with yours. I also added you as a maintainer. I build an upgrade path which should also upgrade for image_sizes_extras projects. The new version of image_sizes is build on responsive_image module from core so we don't need to maintain our custom data model anymore.

I will test the 4.x version on my projects and if everything works well I will make a new release. At this point you probably should flag this project as deprecated and lead users to the image_sizes module. Thx!

Thx,
I'll try to have a look this week.
I was kinda busy recently.

Automatically closed - issue fixed for 2 weeks with no activity.