Should you not get the credit with the commit ?
Very cool. Thx.
You can implement a theme negotation for dashboards https://www.webomelette.com/choose-your-theme-dynamically-drupal-8-theme...
Hard to achieve. If somebody has a resolution feel free to post it here.
Erik Seifert → made their first commit to this issue’s fork.
Erik Seifert → made their first commit to this issue’s fork.
leymannx → credited Erik Seifert → .
We need a log entry as warning.
Having a log message would be a good addition. The file should be there, so it's warning.
I would replace the current js implementation. It seems more comfortable and modern.
Erik Seifert → created an issue.
Erik Seifert → made their first commit to this issue’s fork.
Erik Seifert → made their first commit to this issue’s fork.
Erik Seifert → made their first commit to this issue’s fork.
Okay seems to be removed from 10.0.0 https://www.drupal.org/project/drupal/issues/2979588 →
We should have a better label than "Include destination". Something like "Return to dashboard after create content".
Thank you for support and work on this module. And after your patch is looking very nice. I like it ;-) Seems your MR does not have any changes, so i commit the patch.
Does it also applies to 2.1.x ?
I think matomo query do not have a accessCheck. https://git.drupalcode.org/project/dashboards/-/blob/39b94da4ea4f048770b...
Erik Seifert → made their first commit to this issue’s fork.
Yes it is a colleague from we. Works about 10 years with drupal projects.
@hchonov. This setting is handled by klaro itself. The modal is not the second screen. There is also a cookie banner, but that's not the modal.
Looks for me that is works like designed.
See first screenshot shows only the small cookie banner in the bottom.
Second shows the modal without any possibility to close.
Seems for me the correct behavior.
Erik Seifert → created an issue.
Erik Seifert → created an issue.
- Added eslint config to have an easy check
- Utilize once in klaro.js
Erik Seifert → created an issue.
@elber feel free to test.
I have some findings with the tests.
- Added none initiated plugin manager
- Add correct behavior for empty exclude_paths
- Better block rendering (Bypass if user has the permission)
Tests will be running if ✨ Use klaro settings for excluded paths in block settings and add cache for render array Fixed is merged
The current schema files does not apply any schema on simple_klaro.settings. Update hook ist not needed here.
See 🐛 Config schema incorrect name Closed: duplicate