Fix the issues reported by phpcs

Created on 29 September 2023, about 1 year ago
Updated 1 September 2024, 4 months ago
📌 Task
Status

Needs work

Version

3.0

Component

Code

Created by

🇵🇭Philippines Zed9

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Zed9
  • Merge request !9Fix phpcs issues → (Open) created by Unnamed author
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    Waiting for branch to pass
  • 🇩🇪Germany Erik Seifert

    Having a log message would be a good addition. The file should be there, so it's warning.

  • Status changed to Needs review about 1 year ago
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    Waiting for branch to pass
  • Status changed to Needs work about 1 year ago
  • 🇮🇳India aayushDrupal

    Hi Akshat26,
    Patch #4 failed to apply, leading to unresolved PHPCS errors. For further details, please check the attached screenshot.

    Changing status to "Needs work".
    Thank you.

  • Assigned to Gautam_105@
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    Waiting for branch to pass
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • 🇮🇳India Gautam_105@

    Hi aayushmankotia,
    I have fixed PHPCS reported issue and created MR for the same. Please review and see screenshot.

  • Status changed to Needs work 12 months ago
  • 🇵🇭Philippines paraderojether

    Hi Gautam_105,

    I reviewed MR!9, and there are still remaining phpcs errors/warnings shown below:

    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/js/image-sizes.es.js
    --------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    --------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/README.md
    ---------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------
     38 | WARNING | Line exceeds 80 characters; contains 86 characters
     54 | WARNING | Line exceeds 80 characters; contains 84 characters
    ---------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Form/ImageSizesPresetEntityForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
     77 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     81 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
     87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Plugin/Field/FieldFormatter/ImageSizesPresetFormatter.php
    -------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------------------------------------------------------------
      44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
      88 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     124 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    -------------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Commands/GenerateImageSizeCommand.php
    -----------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    -----------------------------------------------------------------------------------------------------------------------------------
     140 | WARNING | Unused variable $smallesStyle.
     143 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
     204 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     206 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     288 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     291 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     301 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    -----------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Commands/AddFormatCommand.php
    ---------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------------
     76 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    ---------------------------------------------------------------------------------------------------------------------------
    
    Time: 345ms; Memory: 12MB

    Moving this to Needs Work.
    Kindly check and advise, please.
    Thank you.

  • Assigned to pray_12
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 12 months ago
    Waiting for branch to pass
  • Issue was unassigned.
  • Status changed to Needs review 12 months ago
  • Status changed to Needs work 4 months ago
  • 🇩🇪Germany Hydra

    Thx for the work on that. I added some feedback to the MR.

Production build 0.71.5 2024