Contrib.social

Use klaro settings for excluded paths in block settings and add cache for render array

Open on Drupal.org →
Created on 20 January 2023, almost 2 years ago
Updated 23 January 2023, almost 2 years ago

Problem/Motivation

As a site builder, i want to place a klaro block going side by side with klaro settings. If i set exclude_paths in klaro configuration, the block should also not displayed on these paths.

As you see in 🐛 Config schema incorrect name Closed: duplicate the test testExcludePaths will fail because it tests also the block visibility.

Caching seems also not respected. So if you change the title in klaro_settings and revisit the site with an anonymous user, title stays the same.

Steps to reproduce

Set klaro block in a region. Exclude a path in klaro settings. Go to the url and the block is still present and not functional.

Proposed resolution

Use klaro settings in Block::blockAccess . Add the cache dependencies on block and library rendering.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany Erik Seifert

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024