- Issue created by @dydave
- Merge request !34Issue #3439495 by DYdave: Automated testing on GitlabCI: Fixed phpunit errors:... → (Merged) created by dydave
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Status changed to Needs review
6 months ago 5:22am 11 May 2024 - 🇫🇷France dydave
Quick follow-up on this issue:
All tests now seem to be passing green 🟢\o/ 🎉
https://git.drupalcode.org/issue/dashboards-3439495/-/pipelines/170298We would greatly appreciate if you could please try testing the changes from MR!34 and give us your feedback.
Bumping issue to Major as an attempt to get maintainers' attention:
The PHPUnit tests have been fixed and all other jobs integrated on gitlabci are now passing as well ✅In any case, feel free to let us know if you have any questions or concerns on merge request MR!34 or any aspects of this ticket in general, we would surely be happy to help.
Thanks in advance! - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7last update
6 months ago Waiting for branch to pass -
Erik Seifert →
committed 0e97edd5 on 2.1.x authored by
DYdave →
Issue #3439495 by DYdave: Automated testing on GitlabCI: Fixed phpunit...
-
Erik Seifert →
committed 0e97edd5 on 2.1.x authored by
DYdave →
- Status changed to Fixed
6 months ago 8:09pm 22 May 2024 - 🇫🇷France dydave
Wow! Super happy about that Eric (@Erik Seifert)!
Thanks a lot for merging the changes!
The module is now passing all green 🟢 \o/ 🎉
2.1.x: https://git.drupalcode.org/project/dashboards/-/pipelines/179454Any further merge request or ticket should now be able to validate through all the tests/jobs, preventing any regression from being introduced in the module.
This was pretty much the objective of this issue, therefore, at this point we can consider that all the work to be carried in this ticket has been completed, thus marking it as fixed for now.
Feel free to let us know at any point if you have any questions or would see any additional task that we could have missed, we would certainly be glad to hear your feedback.
Thanks again very much Eric for your prompt and positive feedback.
Cheers! - Status changed to RTBC
6 months ago 8:16pm 22 May 2024 - 🇫🇷France dydave
@Erik Seifert:
Not sure exactly how this works, but I would greatly appreciate if you could please mark the issue as fixed and potentially credit me for the issue, if possible.
Ideally, I'd like it to appear on my company's page, on whose behalf I was able to contribute all the work in this issue and I'm sure you would understand.
It looks like when I'm marking the ticket as Fixed, I don't seem to be getting any credit, "perhaps" because I'm not a maintainer of the module.
In any case, thanks a lot for your help reviewing and merging the changes from this ticket into module's main development branch.
Thanks in advance!
-
Erik Seifert →
committed af827e16 on 2.1.x
Issue #3439495 by DYdave: Automated testing on GitlabCI: Fix build...
-
Erik Seifert →
committed af827e16 on 2.1.x
- Status changed to Fixed
6 months ago 3:17pm 4 June 2024 - 🇫🇷France dydave
Super nice of you Erik (@Erik Seifert)! Thanks a lot!
I've just checked and the ticket appears correctly on the company page!
My colleagues will be pleased 🙂Thanks again Erik for your reactivity and great help fixing this issue, it's super appreciated!
Cheers! Automatically closed - issue fixed for 2 weeks with no activity.