Automated testing on GitlabCI: Fix build pipelines errors

Created on 8 April 2024, 8 months ago
Updated 18 June 2024, 5 months ago

Thanks a lot Erik (@Erik Seifert) for all the great work on the module, and more recently, fixing some of the phpcs and phpstan errors.

Problem/Motivation

However, based on a recent build:
https://git.drupalcode.org/project/dashboards/-/pipelines/138918

It would seem quite a few jobs are still showing errors:

  • cspell
  • eslint
  • phpcs
  • phpstan
  • stylint
  • phpunit

 

Steps to reproduce

Build pipeline at:
https://git.drupalcode.org/project/dashboards/-/pipelines

Proposed resolution

Fix all errors reported by all CI jobs, until they all pass green ✅
 

Feel free to let us know if you have any questions or concerns on the work expected or any aspects of this ticket in general, we would surely be glad to provide more information.
Thanks in advance!

📌 Task
Status

Fixed

Version

2.1

Component

Code

Created by

🇫🇷France dydave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dydave
  • Pipeline finished with Success
    8 months ago
    Total: 618s
    #141117
  • Pipeline finished with Running
    8 months ago
    #141121
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    #142645
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    7 months ago
    Total: 1337s
    #170203
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    7 months ago
    Total: 1110s
    #170206
  • Pipeline finished with Success
    7 months ago
    Total: 1610s
    #170212
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    7 months ago
    Total: 178s
    #170221
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    7 months ago
    #170232
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    7 months ago
    Total: 208s
    #170234
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 960s
    #170240
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 206s
    #170261
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Canceled
    6 months ago
    Total: 63s
    #170267
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 206s
    #170268
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 266s
    #170284
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 177s
    #170286
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 208s
    #170295
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 208s
    #170298
  • Status changed to Needs review 6 months ago
  • 🇫🇷France dydave

    Quick follow-up on this issue:

    All tests now seem to be passing green 🟢\o/ 🎉
    https://git.drupalcode.org/issue/dashboards-3439495/-/pipelines/170298

    We would greatly appreciate if you could please try testing the changes from MR!34 and give us your feedback.

    Bumping issue to Major as an attempt to get maintainers' attention:
    The PHPUnit tests have been fixed and all other jobs integrated on gitlabci are now passing as well ✅

    In any case, feel free to let us know if you have any questions or concerns on merge request MR!34 or any aspects of this ticket in general, we would surely be happy to help.
    Thanks in advance!

  • Pipeline finished with Success
    6 months ago
    Total: 179s
    #175491
  • Pipeline finished with Success
    6 months ago
    Total: 178s
    #175501
  • Pipeline finished with Success
    6 months ago
    Total: 240s
    #175506
  • Pipeline finished with Success
    6 months ago
    Total: 210s
    #175510
  • Pipeline finished with Success
    6 months ago
    Total: 179s
    #176522
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
    last update 6 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    6 months ago
    Total: 178s
    #176527
  • 🇩🇪Germany Erik Seifert

    Very cool. Thx.

  • Status changed to Fixed 6 months ago
  • 🇫🇷France dydave

    Wow! Super happy about that Eric (@Erik Seifert)!

    Thanks a lot for merging the changes!

    The module is now passing all green 🟢 \o/ 🎉
    2.1.x: https://git.drupalcode.org/project/dashboards/-/pipelines/179454

    Any further merge request or ticket should now be able to validate through all the tests/jobs, preventing any regression from being introduced in the module.

    This was pretty much the objective of this issue, therefore, at this point we can consider that all the work to be carried in this ticket has been completed, thus marking it as fixed for now.

    Feel free to let us know at any point if you have any questions or would see any additional task that we could have missed, we would certainly be glad to hear your feedback.
    Thanks again very much Eric for your prompt and positive feedback.
    Cheers!

  • Status changed to RTBC 6 months ago
  • 🇫🇷France dydave

    @Erik Seifert:

    Not sure exactly how this works, but I would greatly appreciate if you could please mark the issue as fixed and potentially credit me for the issue, if possible.

    Ideally, I'd like it to appear on my company's page, on whose behalf I was able to contribute all the work in this issue and I'm sure you would understand.

    It looks like when I'm marking the ticket as Fixed, I don't seem to be getting any credit, "perhaps" because I'm not a maintainer of the module.

    In any case, thanks a lot for your help reviewing and merging the changes from this ticket into module's main development branch.

    Thanks in advance!

  • 🇩🇪Germany Erik Seifert

    Should you not get the credit with the commit ?

  • Status changed to Fixed 6 months ago
  • 🇫🇷France dydave

    Super nice of you Erik (@Erik Seifert)! Thanks a lot!

    I've just checked and the ticket appears correctly on the company page!
    My colleagues will be pleased 🙂

    Thanks again Erik for your reactivity and great help fixing this issue, it's super appreciated!
    Cheers!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024