Contrib.social

Improve Gin Admin theme support.

Open on Drupal.org →
Created on 19 March 2024, 6 months ago
Updated 2 April 2024, 6 months ago

Problem/Motivation

The Dashboards toolbar is missing and icon and looks slightly off via the Gin Admin Theme.

First, the Dashboards toolbar tray has extra padding on the left because it uses an item_list instead of links.

I know the example code uses an item list, but most modules are using links.

@see https://api.drupal.org/api/drupal/core%21modules%21toolbar%21toolbar.api...
@see shortcut_renderable_links()
@see user_toolbar()

Second, the Dashboards tab in the Gin Admin Theme reloads the pages because it is the page's route. It seems more helpful via the Gin Admin Theme for it to load the first dashboard.

Third, the Dashboards tab is missing an icon.

Steps to reproduce

Use the Gin Admin Theme with Dashboards

Proposed resolution

  • Adjust the Dashboards toolbar tray to use links instead of an item list.
  • Adjust Dashboard tab URL to use the first dashboard
  • Add icon to Dashboard tab for the Gin Admin theme

Before

After

Remaining tasks

  • Create MR
  • Review MR
  • Merge MR

User interface changes

Adjusting markup for Dashboards to toolbar tray.

API changes

N/A

Data model changes

N/A

📌 Task
Status

Fixed

Version

2.1

Component

Code

Created by

🇺🇸United States jrockowitz Brooklyn, NY

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024