- Issue created by @asherry
- πΊπΈUnited States asherry
I forgot to mention that in the configuration form there is an accent in the title "MenΓΌ items". I fixed that as well in this same patch, but let me know if I should create another ticket.
- Assigned to Erik Seifert
- Status changed to Needs review
over 1 year ago 12:09pm 22 March 2023 - π©πͺGermany Erik Seifert
We should have a better label than "Include destination". Something like "Return to dashboard after create content".
- Issue was unassigned.
- πΊπΈUnited States asherry
I was just following precedent, the views entity operation links has the same label.
Drupal\views\Plugin\views\field\EntityOperations
$form['destination'] = [ '#type' => 'checkbox', '#title' => $this->t('Include destination'), '#description' => $this->t('Enforce a
destination
parameter in the link to return the user to the original view upon completing the link action. Most operations include a destination by default and this setting is no longer needed.'), '#default_value' => $this->options['destination'], ];I'm not saying I'm in love with the label of "include destination" but at least for developers it matches other interfaces, and it's clearer as to what will actually happen. "Return to dashboard after create content" to me might mean we'd be doing a redirect.
Is there an ability also for these dashboard blocks to be placed with the regular block layout? Or might there be anything in the future for placing a dashboard entity in another context? That would also be confusing for this label.
Maybe, "Include destination query parameter"?
-
Erik Seifert β
committed 5d06b35a on 2.1.x
Issue #3349167 by asherry, Erik Seifert: Include destination option for...
-
Erik Seifert β
committed 5d06b35a on 2.1.x
- Status changed to Fixed
over 1 year ago 8:59am 26 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.