- Issue created by @f0ns
- ๐ง๐ชBelgium f0ns
I've added the css to fix this:
https://git.drupalcode.org/issue/drupal-3531516/-/commit/8fda91d0d4805a5...
I've patched my sites with it and everything works as expected now.
- ๐ช๐ธSpain pierregermain
Hello,
This issue still requires some adjustments.
For example, on the /user/1 page, the element still doesn't take up 100% of the height.
I havenโt tested it on other pages yet.Screenshot:
I have used gitpod (drupal 11.2.1-dev)
- ๐ช๐ธSpain pierregermain
Iโve tested the patch on various admin pages, and it works as expected.
Many thanks to f0ns for the fix! - ๐ง๐ชBelgium f0ns
Thank you for testing, iโll leave it on needs review for now and see if we can have an extra pair of eyes on this one.
- ๐บ๐ธUnited States xjm
Thanks @f0ns. Your issue fork seems to be out of sync or perhaps created against a different source branch. Can you create a branch and merge request containing only the commit for your fix? Thanks!
- Merge request !12437Issue #3531516: Admin toolbar height is not 100% since upgrading to Drupal 11.2 โ (Closed) created by f0ns
- Merge request !12438Issue #3531516 :Admin toolbar height is not 100% since upgrading to Drupal 11.2 โ (Open) created by f0ns
- ๐ฎ๐ณIndia sandip
I go though the issue and got that this issue is occured beacuse of
block-size: calc(100vh - var(--drupal-displace-offset-top, 0px));
see the codebase link Code Link in line 95. In olivero frontend theme--drupal-displace-offset-top
is set to 64px that's why navigation bar height is not getting 100%. In claro Admin theme i saw that--drupal-displace-offset-top
is set not defined so we can see full height of navigation bar in claro. I am attaching images for clarity. Please share your thoughts. - ๐ฎ๐ณIndia sandip
I think may be we can remove the line
block-size: calc(100vh - var(--drupal-displace-offset-top, 0px));
Before:
@media (min-width: 64rem) { .admin-toolbar { block-size: calc(100vh - var(--drupal-displace-offset-top, 0px)); transform: none; inset-block-start: 0; } }
After:
@media (min-width: 64rem) { .admin-toolbar { transform: none; inset-block-start: 0; } }
- ๐ง๐ชBelgium f0ns
You might be right, I did not notice this css at first.
Iโll test this and get back on this.