- Issue created by @das-peter
- 🇨🇭Switzerland das-peter
First stab at an integration done.
Allows now to build stuff like this:
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks for your interest in the module and for the MR.
I will ping on ECA slack channel, to ask for a review from people more accustomed to ECA code to ask if the implementation is correct. even if it looks great!
Then I will handle the code quality parts. As it has been a long time since the pipeline has been executed, PHPStan and Coder rules had evolved since then.
- 🇫🇷France Grimreaper France 🇫🇷
Thanks @jurgenhaas for the review!
@das-peter Can you update the MR regarding the review points please?
Then I will finish code quality stuff.
- 🇫🇷France Grimreaper France 🇫🇷
Regarding the experience I had with https://www.drupal.org/project/eca_entity_share →
And regarding the approach we do in https://www.drupal.org/project/ui_suite: →
- one module and sub-modules for Core integrations
- when integrating with another contrib modules we do a separated project.I think it will be better to have an eca_file_extractor dedicated project so it can live at its on speed.