- Issue created by @Grimreaper
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This seems reasonable to me
- First commit to issue fork.
- Merge request !12304#3514079: Added theme negociator to allow contextual links to be rendered in... β (Open) created by nicoloye
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Left some comments on the MR - thanks for working on this
- π«π·France nicoloye
I updated the code, still need tests to be written.
- π«π·France Grimreaper France π«π·
Hi,
Thanks for the MR.
I have updated it to make tests pass.
Also tested with π Access to footer settings Active , works perfectly thanks.
I left a review comment.
Passing to RTBC to get maintainers feedback.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Left some comments on the review, mostly nits, the one around null return from ::getCurrentRequest and addressing the local storage key are blocking the rest are minor
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Crediting adam who left a review in gitlab
- π«π·France Grimreaper France π«π·
Hi,
If I don't miss any, all review comments had been addressed.
So back to RTBC?