Render contextual links taking the current page theme into account

This seems reasonable to me

Left some comments on the MR - thanks for working on this

I updated the code, still need tests to be written.

Hi,

Thanks for the MR.

I have updated it to make tests pass.

Also tested with 🐛 Access to footer settings Active , works perfectly thanks.

I left a review comment.

Passing to RTBC to get maintainers feedback.

Thanks for the review.

Left some comments on the review, mostly nits, the one around null return from ::getCurrentRequest and addressing the local storage key are blocking the rest are minor

larowlan → credited acbramley → .

Crediting adam who left a review in gitlab

Hi,

Review points addressed.

Hi,

If I don't miss any, all review comments had been addressed.

So back to RTBC?

wrong tag.

And regarding definition:

It denotes an issue that prevents porting of a contributed project to the stable version of Drupal due to missing APIs, regressions, and so on.

Then not a blocker as it prevents a feature and not a stable version.

Left 2 nitpicky comments on the MR, leaving in NR

About PHP attribute conversion of the last code review, in 📌 [meta] Convert test metadata from annotation to attribites Active it is stated:

we can't mix PHPUnit attributes and annotations [in a single file], we will have to convert them all at once unfortunately

So updating the code changed in the MR would require changing code out-of-the-scope of this issue.

If a code conversion in the Contextual module happens before the merge of this issue then I will update it, otherwise I prefer to keep it aligned with the module current codebase.