Contrib.social

Twig functions aren't aware of the currently active language

Open on Drupal.org →
Created on 18 February 2025, about 2 months ago

Hi,

First of all thanks for a great library/module, it works like a charm.
I do have a small feature request, it would be nice if the twig function 'site_setting_field(..)' was aware of the current language by default if no language code was provided.

Problem/Motivation

The twig functions aren't aware of the current language right now.
Currently I have to inject the langcode to use it as follows:
{{ site_setting_field('[id]', '[field]', '[view_mode]', langcode) }}
Instead of ideally just:
{{ site_setting_field('[id]', '[field]') }}

That's because Drupal\site_settings\Twig\TwigExtension::singleSiteSettingsByNameAndField does the following:

if ($langcode && $site_setting->hasTranslation($langcode)) {
  $site_setting = $site_setting->getTranslation($langcode);
}

Proposed resolution

Let's make it so that if no langcode was provided, the current language id is given.
I suppose the above code snippet would have to become:

$langcode = $langcode ?? $this->languageManager->getCurrentLanguage()->getId();
if ($site_setting->hasTranslation($langcode)) {
  $site_setting = $site_setting->getTranslation($langcode);
}

(The language manager will need to be injected in the class still)

✨ Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium RandalV

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024