- Issue created by @svendecabooter
- First commit to issue fork.
- 🇧🇪Belgium svendecabooter Gent
MR introduces PHPCS / PHPStan issues, which would ideally be resolved before merging.
- 🇧🇪Belgium aren33k
@svendecabooter agreed on the constructor promotion, but won't this cause issues for drupal 9 installations?
- 🇧🇪Belgium svendecabooter Gent
Drupal 9 is no longer officially supported, and OOP hooks only work for 10.1+ anyway
- Assigned to aren33k
- Status changed to Needs work
23 days ago 12:33pm 30 June 2025 - 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
Ah, I had not noticed this issue before. I added a hook_cron implementation in ✨ Add a cleanup function Active and did not use this pattern because of the Drupal 9 support (although I may have used some PHP features that rule out D9, not sure🫢). Will probably depend on the sequence of merging what needs to be adapted to what.
-
svendecabooter →
committed 75a4340a on 1.0.x authored by
aren33k →
Issue #3519842 by aren33k, svendecabooter: Support OOP hooks
-
svendecabooter →
committed 75a4340a on 1.0.x authored by
aren33k →
- 🇧🇪Belgium svendecabooter Gent
Remaining issues have been resolved, and this has been added to 1.0.x branch.
@eelkeblok would be good if you could rebase your MR branch on 1.0.x and also add support for OOP hooks. Sorry for the extra work. Automatically closed - issue fixed for 2 weeks with no activity.