Disable (Quick) Edit in secondary toolbar

I think it would be a bit overkill to add a setting just for that. Instead we can just check if the module is active and not render the link if not.

I agree it is likely overkill, plus it's not very intuitive to find that setting. But I wasn't sure how others would feel.

Assigning this to myself to work on.

Hi there.

After digging into this issue some more, the issue seems to be unrelated to Quick Edit. It seems that the Edit link AND Local Tasks links displayed in the secondary toolbar are driven by Core and Admin Toolbar Extras.

So this issue title probably should be changed to reflect the issue being looked at.

Proposed changes:

• Update the icon (sprite) that Gin assigns to the Local Tasks link when it is available. To avoid confusion.

Two additional thoughts based on feedback I have received from multiple content editors:

1. Hide or change Edit text to more clearly reflect its function. I have heard some feedback from site users that the Edit link is confusing just because they expect to click it and edit the node. Since this link comes from Core and Admin_toolbar which is a very popular module we should be careful in how we handle.
2. Change the link text for Local Tasks to "Edit Page" to be more intuitive for editors. Local Tasks is not very meaningful for non-devs.

We potentially could look into changing the icon for Local Tasks. However for the other proposed changes you’ll have to open issues in the given modules.

Hide or change Edit text to more clearly reflect its function. I have heard some feedback from site users that the Edit link is confusing just because they expect to click it and edit the node. Since this link comes from Core and Admin_toolbar which is a very popular module we should be careful in how we handle.

Most likely would be something to discuss in the quickedit module.

Change the link text for Local Tasks to "Edit Page" to be more intuitive for editors. Local Tasks is not very meaningful for non-devs.

To be discussed wherever this label comes from.

Cheers

After further exploration of this issue, it's clear that the proposed changes should be handled in the Gin theme instead. So I am closing this one and creating a new issue over there! thanks