Contrib.social

Disable (Quick) Edit in secondary toolbar

Open on Drupal.org →
Created on 20 January 2023, almost 2 years ago
Updated 22 February 2023, almost 2 years ago

Edit link in secondary toolbar supports a deprecated core module: Quick Edit

Quick Edit has been deprecated in Drupal core so having the Edit link present is only relevant if using the Quick Edit → legacy contrib module.

Steps to reproduce

If you click on the Edit link, it highlights elements on page that are editable, but when you click the contextual link to edit, it simple opens the node edit form.

Proposed resolution

Initial suggestion: Add a boolean toggle button under Show Secondary Toolbar in Frontend on Gin admin settings page to enable the Edit link, it would be disabled by default. Perhaps have the toggle disabled if the Quick Edit module is not enabled?

✨ Feature request
Status

Closed: works as designed

Component

User interface

Created by

🇺🇸United States galactus86

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States galactus86

    I think it would be a bit overkill to add a setting just for that. Instead we can just check if the module is active and not render the link if not.

    I agree it is likely overkill, plus it's not very intuitive to find that setting. But I wasn't sure how others would feel.

  • Assigned to galactus86
  • Comment almost 2 years ago →
    🇺🇸United States galactus86

    Assigning this to myself to work on.

  • Comment almost 2 years ago →
    🇺🇸United States galactus86

    Hi there.

    After digging into this issue some more, the issue seems to be unrelated to Quick Edit. It seems that the Edit link AND Local Tasks links displayed in the secondary toolbar are driven by Core and Admin Toolbar Extras.

    So this issue title probably should be changed to reflect the issue being looked at.

    Proposed changes:

    • Update the icon (sprite) that Gin assigns to the Local Tasks link when it is available. To avoid confusion.

    Two additional thoughts based on feedback I have received from multiple content editors:

    1. Hide or change Edit text to more clearly reflect its function. I have heard some feedback from site users that the Edit link is confusing just because they expect to click it and edit the node. Since this link comes from Core and Admin_toolbar which is a very popular module we should be careful in how we handle.
    2. Change the link text for Local Tasks to "Edit Page" to be more intuitive for editors. Local Tasks is not very meaningful for non-devs.
  • Comment almost 2 years ago →
    🇨🇭Switzerland saschaeggi Zurich

    We potentially could look into changing the icon for Local Tasks. However for the other proposed changes you’ll have to open issues in the given modules.

    Hide or change Edit text to more clearly reflect its function. I have heard some feedback from site users that the Edit link is confusing just because they expect to click it and edit the node. Since this link comes from Core and Admin_toolbar which is a very popular module we should be careful in how we handle.

    Most likely would be something to discuss in the quickedit module.

    Change the link text for Local Tasks to "Edit Page" to be more intuitive for editors. Local Tasks is not very meaningful for non-devs.

    To be discussed wherever this label comes from.

    Cheers

  • Issue was unassigned.
  • Status changed to Closed: works as designed almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States galactus86

    After further exploration of this issue, it's clear that the proposed changes should be handled in the Gin theme instead. So I am closing this one and creating a new issue over there! thanks

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024