- Issue created by @Harish1688
- Status changed to Needs review
over 1 year ago 7:39am 19 April 2023 - 🇮🇳India Harish1688 India
Hi,
Created a patch for this issue, please review the patch Local-Task-menu-item-alignment-3355036-1.patch .
After patch image attached. - Status changed to RTBC
over 1 year ago 12:49pm 3 May 2023 This patch is working, the menu items are now aligned to the left. Moving it to RTBC.
- 🇺🇸United States galactus86
I had this on my list to tackle... nice work! Verified the patch works!
- Assigned to galactus86
- Status changed to Needs work
over 1 year ago 5:30pm 3 May 2023 - 🇺🇸United States galactus86
While initial test works, when reviewing the code I see that the dist/.css file was changed NOT the .scss file. So next time anyone compiles the CSS this change will be lost.
I'm going to take a few minutes and update.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:46pm 3 May 2023 - 🇺🇸United States galactus86
Updated the toolbar_secondary.scss file instead so it compiles correctly and won't get over written in the future. I also removed the float as a best practice.
Patch attached for review.
- First commit to issue fork.
- Status changed to RTBC
over 1 year ago 7:05am 12 May 2023 - 🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
Unsetting the float is a neater solution, then adding extra styling.
Using patch #6
The bug in our case:
With the patch:
thnx!
-
saschaeggi →
committed f918f092 on 8.x-3.x authored by
galactus86 →
Issue #3355036 by Harish1688, galactus86, sahal_va: Theme issue with...
-
saschaeggi →
committed f918f092 on 8.x-3.x authored by
galactus86 →
- Status changed to Fixed
over 1 year ago 7:31pm 22 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.