Account created on 16 January 2018, about 7 years ago
  • Senior Drupal Engineer at Axelerantย  โ€ฆ
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

I believe this is occurring after https://www.drupal.org/project/drupal/issues/3198236 ๐Ÿ› "Add another" buttons could use vertical margin Fixed ?
See the changes in core/themes/claro/css/components/form.css

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ changed the visibility of the branch 3302712-scrolltoelementcommand-ajax-error to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

It seems https://github.com/ckeditor/ckeditor5/issues/14933 is fixed in ckeditor5 and hope will be included in next release.
Can we make this issue active?

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

I've tested the patch in #100 with Drupal 10.1.5 and GIN 3.0.0-rc7. It resolves the issue for me.

@Anybody
Created a MR

- Changing to Needs review

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

Hi @dernetzjaeger

This might help https://www.drupal.org/project/oauth2_server/issues/3366668 ๐Ÿ› module stopped working after library upgrade RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

I have similar issue after updating this module. Did you find any solution/workaround ? @pobster

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

sahal_va โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

I am also getting the same issue mentioned in https://www.drupal.org/project/gin/issues/3338209 ๐Ÿ› Sticky header triggered to early Closed: outdated
Issue occurs only when the table view has more number of columns. (ie. when the horizontal scroller appears)
See screenshot.

Note: Horizontal scroller div has ' --is-sticky' class

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

Attaching a patch for this issue.
Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

RTBC + 1

Reviewed patch in #2 and it is working fine.
Tested with Drupal Core 10.0.9

Before Patch:

After Patch:

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

Hey @saschaeggi,

This is still an issue in following case.

When the user has a lot of exposed filters and a small browser window, this will cause e.intersectionRatio < 1 to be true (since the thead is not visible) and triggers the sticky header.

OR

Zoom the window / Open inspector window and adjust screen height till half the table header is visible.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sahal_va

Hi @Gauravvvv

Thanks for working on this.

Now VBO counter works fine when the "Select all" is checked in non-sticky mode.

But "Select all" checkbox is missing in sticky header.

And there is a console error

Production build 0.71.5 2024