module stopped working after library upgrade

Created on 14 June 2023, over 1 year ago
Updated 21 March 2024, 9 months ago

Problem/Motivation

Module stoped working with new version of bshaffer/oauth2-server-php

Steps to reproduce

Just install the module as it is, its composer.json requires bshaffer ^1.7.
Works with 1.13 but it has stopped working with 1.14, which implements PKCE.

fatal error: Declaration of Drupal\oauth2_server\OAuth2Storage::setAuthorizationCode($code, $client_id, $uid, $redirect_uri, $expires, $scope = null, $id_token = null) must be compatible with OAuth2\OpenID\Storage\AuthorizationCodeInterface::setAuthorizationCode($code, $client_id, $user_id, $redirect_uri, $expires, $scope = null, $id_token = null, $code_challenge = null, $code_challenge_method = null) /var/www/drupalvm/web/modules/contrib/oauth2_server/src/OAuth2Storage.php on line 536

Proposed resolution

Simplest way is to force the use of 1.13, but i also tried to alter interface signature to the new signature and it seems to work.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain Pandepoulus

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024