Contrib.social

Automated Drupal 10 compatibility fixes for upgrade_rector

Open on Drupal.org →
Created on 23 July 2022, over 2 years ago
Updated 29 September 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    2 fail
  • Comment over 1 year ago →
    🇺🇸United States neclimdul Houston, TX

    The irony of this not being done. LOL

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇬🇧United Kingdom 3li U.K. 🇬🇧

    Tested #9 and found it also happy on upgrade status.
    Also re-rolled the patch to work with alpha8

  • Comment over 1 year ago →
    leksat

    RTBC++

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    Project Update Bot

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module → this patch makes this module compatible with Drupal 10! 🎉
    Therefore this patch updates the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #12554

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.35
    2. palantirnet/drupal-rector: 0.15.1
  • First commit to issue fork.
  • @sahal_va opened merge request.
  • Comment about 1 year ago →
    🇮🇳India sairamraavi

    #14 patch is working as expected.

  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇭🇺Hungary Gábor Hojtsy Hungary

    Re @neclimdul:

    The irony of this not being done. LOL

    The module already works fine on Drupal 9 with 8.x-1.0-alpha8, so the Drupal 10 compatible version would be needed to move from Drupal 10 to 11 I think. It is true that having a 9 and 10 compatible version helps with the upgrade since you don't need to remove the module before updating to Drupal 10, but you should remove it anyway as it is not needed for your Drupal 10 site operation.

    I committed a heavily modified version of the above and made a 2.x branch with that.

    1. The file_directory_temp() backwards compatible code should not have been fixed but removed. That was for supporting Drupal 8.
    2. The drupal_get_path() should not have been removed but converted to a backwards compatible wrapper so Drupal 9 earlier than 9.3.0 could use the module.
    3. This allowed to update the info file to also support any version of 9.
    4. The test module should not have been "fixed" since it intentionally has outdated calls so rector fixes it and we test for that.
    5. However the test module info file should have been updated to allow it to be installed on Drupal 10 too for testing.

    Committed that.

    All in all I think this module should have a tiny role in site upgrades, it is not very convenient where it outputs a patch in a textarea that you need to copy somewhere and apply to your codebase. For you local codebase using rector on the command line is vastly preferred. For d.o patch generation, the project update bot took that role over, so copying patches from a textarea is not the way anymore. So I am wondering what people use this module for still :)

  • Comment about 1 year ago →
    🇭🇺Hungary Gábor Hojtsy Hungary

    Added this to the project page:

    If you plan to use the automated fixes as well, it is easier to use Drupal Rector directly on the command line to apply the automated fixes immediately. In that case this module is not needed at all as the assesment functionality is also directly available in Drupal Rector with the --dry-run option.

  • Comment about 1 year ago →
    System Message
  • Comment about 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024