Fixed some button name conflicts on functional tests as well
Initial patch test. Need to write some tests
npaudyal001 → created an issue.
This should do it!
Got it. The patch didn't include the new files. SMH..
For some reason, it can't find the button 'Save Token'. Trying to printout the page content now to see whats going on
@Eduardo, thanks for the fix. Looks good to me!
This has been released on a new 4.1.x-dev branch and 4.1.0 official release branch. There are still drupal check errors associated with phpUnit 10 deprecations for which we will open a new issue. Thank you all!
Not very helpful! Trying to update the dependency through dupalCI custom commands.
Drupal core 9.5 still uses guzzle 6 which has deprecation issues with php 8 and >. Trying to include patches for that in composer.json file
@sja112, thanks for pointing that out. Heres the updated patch.
@murrow, I don't see a way to update that page. It looks like thats a drupal default version control page for all modules.
Tablefield module is not yet compatible with php8.2, thats why its throwing errors. Other than that, with this patch we should be good. And @murrow, its probably a good idea to update that page.
Further coding standard fixes.. Also, if you are applying this patch please include binary option to pull the diagnostic dump file thats added for the update tests.
Further fixes...
Metatag fix
Added missing binary files and fixed some file renames.
Fixing changes related to group module and further updates
Ignoring the legacy tests that required database snapshot from older lingotek database structure.
Fixing CI error
Further updates. Replaced some older diagnostic dumps with newer ones as drupal 10 required updated ones.
Unit test fixes + additional updates
Further fixes on functionals.
Further updates. Continuing from #64.
Fixing the corrupt patch, #65. Same with this... ignore this patch
@murrow Ignore this patch. I am testing one of the previous patches. There seems to be a lot of functionality breaking changes coming from phpstan fixes. Just trying to run the test with this patch and see whats the result.
More updates...
@murrow, I am also seeing other changes in LingotekContentTranslationService.php and lingotek.module, where the fields are being set in a separate variable $content_metadata_entity and thus the original entity object remains unchanged. This is breaking functionalities. Were this changes made to handle PHPStan errors? We might need to roll that back too I suppose?
Thanks @murrow. Updating composer.json with new d10 supporting webform module. This should fix the composer failure.
@murrow, I am seeing some things missing from these patches. For example, I am not seeing the class LingotekConfigurationTrait.php from patch #46 in the recent patches which seems to be causing errors. Looking more into it.
Fixing patch conflict
Thanks @murrow. I apologize for disappearing all these days. Had some health issues. Here is a patch with some more updates.
More fixes to the unit tests suggested by drupal check. Includes rewriting tests without at() matcher and withconsecutive().
With #16, 100% tests are passing on my local, not sure whats the deal with "Composer Config Failure"
@jeromeroberts, With the patch it seems to build fine, but after the commit tests on other patches are throwing composer config error. I am reverting this commit to test if the error is coming from here.
@murrow, Most of the failures that you see on the recent patch was introduced by "Drupal\Core\Field\FieldStorageDefinitionListenerInterface" from the patch #46. As far as other errors, there were only 13 of them from the acquia/cohesion which I am having a hard time resolving but still working on it. I think we should focus on this issue as this is up to date and I will try and have some guys look at the test ticket to catch up.
@murrow, This looks good. I am uploading the patch with some drupalCI fixes so we can run the test against drupal 10.
Resetting the previous commit since we got some fatal errors instead
Adding the fix for drupal CI issue on 4.0.x here
Functional tests should hopefully now be in the clear.
Adding cweagans/composer patches in extras to see if composer failures will go away.
Updating the versions of webform and cohesion to be compatible with d10 in dev dependencies.
This is #32 by removing the yml file diffs since a different commit to it was made.
Committing the yml file to support d10 in 4.0.x since the it doesn't get picked up by patches during automated testing
Fixed some more deprecated tests and module seems to be working from the surface. More tests need to be fixed
npaudyal001 → made their first commit to this issue’s fork.
npaudyal001 → made their first commit to this issue’s fork.
npaudyal001 → created an issue.