- Issue created by @DamienMcKenna
- Status changed to Needs review
over 1 year ago 8:23pm 18 May 2023 - last update
over 1 year ago 1,348 pass, 31 fail The last submitted patch, 2: lingotek-n3361327-2.patch, failed testing. View results β
- Status changed to Needs work
over 1 year ago 9:16pm 18 May 2023 - πΊπΈUnited States DamienMcKenna NH, USA
That's good - it's down from 321 failures to only 31.
- last update
over 1 year ago 511 pass, 321 fail - last update
over 1 year ago 1,364 pass, 24 fail - last update
over 1 year ago 1,428 pass, 19 fail - πΊπΈUnited States npaudyal001
Adding the fix for drupal CI issue on 4.0.x here
-
npaudyal001 β
authored ce7aeefe on 4.0.x
Issue #3361327 by npaudyal001, DamienMcKenna: Fix test failures in 4.0.x...
-
npaudyal001 β
authored ce7aeefe on 4.0.x
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago Patch Failed to Apply -
npaudyal001 β
authored 7a19e23d on 4.0.x
Issue #3361327 by npaudyal001, DamienMcKenna: Fix test failures in 4.0.x...
-
npaudyal001 β
authored 7a19e23d on 4.0.x
- πΊπΈUnited States npaudyal001
Resetting the previous commit since we got some fatal errors instead
- π³πΏNew Zealand murrow
A couple of questions here that might help me contribute a little better than I have been.
These tests are required for D10 (so PHP 8.1). This ticket appears to be for D9.5, but it is a blocker for #3288313. And there is also #3344857 that seems to cover this issue + a number of other test-related errors. D9.5 is EOL on 1 November. We also appear to have a D10 build issue that doesn't seem to be resolved in any of these tickets and relates to the composer permissions afforded the cweagans patch library.
My first question is, what is a plan of attack to get Lingotek to D10?
My second question is, given that there are roughly 7,000 phpstan errors thrown up on my D10 build (using Drupal check) on the tests alone and just 19 being thrown for the D9.5 build above and the matter of D9.5 EOL, is it meaningful putting effort into D9.5 at all?
Probably, I am missing something/a whole lot β apologies in advance.
- πΊπΈUnited States DamienMcKenna NH, USA
Trying to fix the build on 9.5 will mean there's a cleaner slate to work from for D10, so that on the D10 issue it'll be easier to tell whether test failures are because of the D10 changes or an existing bug.
- last update
over 1 year ago Composer config failure - last update
over 1 year ago Composer config failure - last update
over 1 year ago Composer config failure - last update
over 1 year ago Composer config failure - last update
over 1 year ago Composer config failure - πΊπΈUnited States npaudyal001
With #16, 100% tests are passing on my local, not sure whats the deal with "Composer Config Failure"
- last update
over 1 year ago Composer config failure - πΊπΈUnited States DamienMcKenna NH, USA
Sounds like an infrastructure problem.
- last update
over 1 year ago 1,571 pass, 5 fail - πΊπΈUnited States DamienMcKenna NH, USA
The composer problems have been fixed elsewhere, the latest patch now just has five errors.
- π³πΏNew Zealand murrow
Yes, I believe that this was covered in #3288313. @npaudyal001, could you confirm and then close this issue please?
- πΊπΈUnited States DamienMcKenna NH, USA
I think if you're going to list the 4.0.x branch as still maintained then the tests should still be fixed. On the other hand, if you're going to mark the 4.0.x branch unsupported then this could be closed.
- last update
about 1 year ago 1,330 pass, 72 fail - last update
about 1 year ago 1,577 pass, 2 fail - last update
about 1 year ago 1,579 pass -
npaudyal001 β
authored fd7d004c on 4.0.x
Issue #3361327 by npaudyal001, DamienMcKenna, murrow: Fix test failures...
-
npaudyal001 β
authored fd7d004c on 4.0.x
- Status changed to Fixed
about 1 year ago 8:30pm 12 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.