Fixing the warnings reported by PHPCS

Addressed the MR comments, please review

In Constructs an ImageStyleImageFormatter object. there is no namespace.

@apaderno Can you clarify a bit more? The namespace is included in as the first line in the class

namespace Drupal\field_image_style\Plugin\Field\FieldFormatter;

Constructs an ImageStyleImageFormatter object. does not contain any namespace. What the namespace for the file is does not matter.

There is a phpcs error on the constructor line. I did the modification.
@apaderno why do we need to change the class name and add the namespace into it ? Actually we have "Plugin implementation of the 'image_style_formatter' formatter." with the "FieldFormatter" annotation.

It does not matter. The construction description must be similar to the following one.

  /**
   * Constructs a \Drupal\user\AccountSettingsForm object.
   *
   * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
   *   The factory for configuration objects.
   * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
   *   The module handler.
   * @param \Drupal\user\RoleStorageInterface $role_storage
   *   The role storage.
   */

  /**
   * Constructs a \Drupal\migrate\Row object.
   *
   * @param array $values
   *   An array of values to add as properties on the object.
   * @param array $source_ids
   *   An array containing the IDs of the source using the keys as the field
   *   names.
   * @param bool $is_stub
   *   TRUE if the row being created is a stub.
   *
   * @throws \InvalidArgumentException
   *   Thrown when a source ID property does not exist.
   */

Conflict: This file was modified in both the source and target branches. Ask someone with write access to resolve it.

I can't modify the line in question because it no longer respects the 80 character rule.
I rebased the branch and removed the added class comment

Hi @bakop,

Applied the changes you committed on MR!2, it was applied smoothly but one error still reported. Please see below:

➜  field_image_style git:(8.x-1.x) curl https://git.drupalcode.org/project/field_image_style/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15536    0 15536    0     0  33434      0 --:--:-- --:--:-- --:--:-- 34070
patching file field_image_style.module
patching file src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
patching file src/Plugin/Field/FieldType/ImageStyleItem.php
➜  field_image_style git:(8.x-1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig field_image_style


FILE: ...d_image_style/src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Core\File\FileUrlGeneratorInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 247ms; Memory: 10MB

Kindly check

Thanks,
Jake

There is still a PHP_CodeSniffer error reported for the merge request.

avpaderno → changed the visibility of the branch 3381506-gitlab-ci-reports to hidden.

Hi

I reviewed MR!2, and confirmed it fixes the phpcs issues reported by the PHP_CodeSniffer.

➜  field_image_style git:(2.0.0) curl https://git.drupalcode.org/project/field_image_style/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17793    0 17793    0     0  41761      0 --:--:-- --:--:-- --:--:-- 42263
patching file .gitlab-ci.yml
patching file field_image_style.module
patching file 'src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php'
patching file 'src/Plugin/Field/FieldType/ImageStyleItem.php'
➜  field_image_style git:(2.0.0) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig field_image_style
➜  contrib git:(main) ✗

It also passed the phpcs using the Gitlab CI.

Moving this to RTBC.
Thank you.