Contrib.social

[Mailjet API] Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 12 November 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇮🇹Italy kopeboy Milan

    The bot suggests we only add || ^10 to the mailjet_api.info.yml file.
    Unfortunately fully testing this requires having a live site and account at mailjet, so I'm not changing the status to reviewed atm.
    Maybe the maintainer could check if we can safely use this with D10 and provide a new release? 🙏🏻

  • First commit to issue fork.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi
    I review the patch applied cleanly, after that I test the d10 comaptible issues no issues found and module is compatible with D10.

    I am attaching screenshot of upgrade status report for D10.

    thanks

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22
    last update over 1 year ago
    1 fail
  • @dineshkumarbollu opened merge request.
  • Comment over 1 year ago →
    🇩🇪Germany stevieb

    I also confirm that the patch is working

  • Comment over 1 year ago →
    🇫🇷France flocondetoile Lyon

    @stevieb Are you using this module on D10. Can you confirm the module (with the patch) works on D10, and not only the patch (a working patch doesn't mean a working moduel) ?

    Anybody else using mail_jet_api on D10 ? (not yet migrated on D10)

  • Comment over 1 year ago →
    🇫🇷France tty11

    Hello,
    For information I wanted to install the module for D10 but I have an error with compose with a dependency of mailjet_api:

    mailjet/mailjet-apiv3-php v1.3.0 requires guzzlehttp/guzzle ~6.0|~5.3

    Core D10 requires guzzlehttp/guzzle ^7.5

    mailjet/mailjet-apiv3-php since version 1.5.0 is ~7.0 compatible and the latest version is 1.5.9

    Then I don't know if the module is compatible with mailjet/mailjet-apiv3-php >= 1.5.0

    I'll try to do some tests, I'll keep you posted.

  • Comment over 1 year ago →
    🇮🇳India manikandank03 Tamil Nadu

    Hello,

    I am also facing the same issue #10 in Drupal 10.1.1, unable to install the latest version of the module.

    Your requirements could not be resolved to an installable set of packages.

    Problem 1
    - Root composer.json requires drupal/mailjet_api == 1.0.0.0 -> satisfiable by drupal/mailjet_api[1.0.0].
    - drupal/mailjet_api 1.0.0 requires mailjet/mailjet-apiv3-php ~1.3.0 -> found mailjet/mailjet-apiv3-php[v1.3.0] but these were not loaded, likely because it conflicts with another require.

    Please update the composer.json file with the latest mailjet-api version(https://github.com/mailjet/mailjet-apiv3-php) and release new version of the module.

    "mailjet/mailjet-apiv3-php" : "^1.5"

    Thanks.

  • First commit to issue fork.
  • Comment about 1 year ago →
    🇫🇷France bakop Lille
  • Assigned to bakop
  • Status changed to Active about 1 year ago
  • Comment about 1 year ago →
    🇫🇷France bakop Lille
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22
    last update about 1 year ago
    4 pass
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇫🇷France bakop Lille

    Hi, there is indeed an issue with the version of the sdk to install the module on Drupal 10.
    I did an email sending test (see attachment).

  • Comment about 1 year ago →
    🇦🇺Australia darvanen Sydney, Australia

    If you come across this and are having trouble getting the module working, you can trick composer into resolving the library with

    "mailjet/mailjet-apiv3-php": "1.6.0 as 1.3.0",

    Then the patch will take care of the rest.

    So far it seems to me that the patch is all good but I'll hold off RTBCing it until it's gone through proper testing

  • Comment about 1 year ago →
    🇫🇷France flocondetoile Lyon

    Committing MR5 to dev branch. I will be able to test on a real project soon. And so publish a new release if tests are OK.

  • Comment about 1 year ago →
    System Message
    • bakop → authored 1ea16b34 on 8.x-1.x 
      Issue #3288422 by dineshkumarbollu, bakop, pvbergen, flocondetoile,...
  • Comment about 1 year ago →
    🇫🇷France flocondetoile Lyon

    Leaving open this issue until a new release is published.

  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇫🇷France flocondetoile Lyon

    Looks good.

  • Comment about 1 year ago →
    🇦🇺Australia darvanen Sydney, Australia

    Hats off to you sir, many thanks for the release.

  • Comment 12 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024