kevineinarsson → created an issue.
The patch doesn't work, s-maxage and max-age are always set to the same value.
The configuration form says that the 3xx/404/5xx max-age value should be the same as 200 responses. If that's the case, why is setClientTtl called?
Rerolled #10 to apply cleanly to dev for people using this patch via Composer.
Attached a test + patch (not a clean patch but it... works(?)) Maybe need to check if these values are null too.
Changed some code from #25 since it broke my normal menu links, the derivative manager was only adding default_menu_tab and menu_tab items to the array of derivatives, as well as some inconsistent usage of the keys "menu" and "menu_name" causing some further issues.
I've also used core's menu link overrides to move some menu links around. With #25, none were applied. When I tried to update some values, the call to updateMenuLink caused a WSOD due to it trying to set the values directly to on page entity (i.e. $page->weight->value) which obviously doesn't exist. Should these overrides even be written directly to the page entity? Why not do what core does where menu link overrides are saved in a separate config entry? makes more sense IMO.