- Issue created by @Rajab Natshah
- Issue was unassigned.
- Status changed to Needs review
4 months ago 7:48pm 12 September 2024 - π―π΄Jordan Rajab Natshah Jordan
Noticed that the fix is in the
pre-release
tag 8.x-3.26-beta1 β
Hopping for the8.x-3.26
tag to be released - π―π΄Jordan Rajab Natshah Jordan
Using the following patch from the direct commit as a TEMP until the release of
3.26.0
"drupal/jsonapi_extras": { "Issue #3473990: Fix PHP Fatal error on Declaration of the normalize function must be compatible with normalize function return type after Schemata 8.x-1.0 was released": "https://git.drupalcode.org/project/jsonapi_extras/-/commit/d7ab37658999b5fae74769ade4155ec7310aa468.diff" }
- π―π΄Jordan Rajab Natshah Jordan
rajab natshah β changed the visibility of the branch 3473990-fix-php-fatal to hidden.
- π±πΊLuxembourg paddy_deburca
I can confirm that after adding the patch reference to
composer.json
and performing acomposer update
I getGathering patches for dependencies. This might take a minute. - Installing drupal/jsonapi_extras (3.25.0): Extracting archive - Installing bower-asset/jqueryui-touch-punch (dev-master 4bc0091): Extracting archive - Applying patches for drupal/jsonapi_extras https://git.drupalcode.org/project/jsonapi_extras/-/commit/d7ab37658999b5fae74769ade4155ec7310aa468.diff (Issue #3473990: Fix PHP Fatal error on Declaration of the normalize function must be compatible with normalize function return type after Schemata 8.x-1.0 was released)
And, after performing an
drush updb
, the command succeeds without failing due tonormalize
compatibility definition issues. - π«π·France JΓ©rΓ΄me Dehorter Lille
Hi,
Patch https://git.drupalcode.org/issue/jsonapi_extras-3473990/-/commit/52aa046...
not working on my Drupal 10.3.2 with Schemata 1.0.0 and JSON:API Extras 3.25.I got this error
Fatal error: Declaration of Drupal\jsonapi_extras\Normalizer\SchemataSchemaNormalizer::normalize($entity, $format = null, array $context = []) must be compatible with Drupal\schemata_json_schema\Normalizer\jsonapi\SchemataSchemaNormalizer::normalize($entity, $format = null, array $context = []): ArrayObject|array|string|int|float|bool|null in /app/drupal/www/modules/contrib/jsonapi_extras/src/Normalizer/SchemataSchemaNormalizer.php on line 35
- Status changed to RTBC
3 months ago 7:11pm 19 September 2024 - πΊπΈUnited States jds1 Hudson Valley, NY
Error goes away after patching per #5, RTBC!
- π©πͺGermany Anybody Porta Westfalica
Thanks, would be great to have this released ASAP. Did someone ping the maintainers already?
- π³π±Netherlands timohuisman Leiden, Netherlands
Can confirm as well that the patch from #5 resolves the problem and that a new release is really needed. One of the maintainers (bbrala) is a colleague of mine, I'll check with him if we can get a release today.
- π³π±Netherlands bbrala Netherlands
I'm always a little scared about these. Won't this break others the other way around? Have other ecosystem modules been tested with this patch?
- π―π΄Jordan Rajab Natshah Jordan
Yes, I had many full testing rounds, Plush automated testing.
Tested the manual update in my personal demo case site
"drupal/core": "~10.3.0 || ~11.0.0", "drupal/consumers": "~1", "drupal/openapi": "~2", "drupal/openapi_jsonapi": "~3", "drupal/openapi_rest": "~2", "drupal/openapi_ui_redoc": "~1", "drupal/openapi_ui_swagger": "~1", "drupal/simple_oauth": "~6", "drupal/schema_metatag": "~3", "drupal/restui": "~1", "drupal/jsonapi_extras": "~3"
With the patch from the commit as in comment #5
- π³π±Netherlands bbrala Netherlands
Sorry, i've completely borked my response here.
I will release a new version sorry :)
- π³π±Netherlands bbrala Netherlands
- π―π΄Jordan Rajab Natshah Jordan
Thanks, BjΓΆrn
Doing further:
- post-release fresh install testing rounds.
- Update testing rounds.
Automatically closed - issue fixed for 2 weeks with no activity.