jds1 β created an issue.
This is still an issue in 1.0.14
jds1 β changed the visibility of the branch 3414591-2.0.3-reroll to hidden.
Welp I tried to use the MR process but I cannot push to the seckit repro. Keeping things old school with this patch/rerolling for 2.0.3
jds1 β changed the visibility of the branch 3414591-clickjacking-css-protection to active.
jds1 β changed the visibility of the branch 3414591-clickjacking-css-protection to hidden.
jds1 β changed the visibility of the branch 3414591-clickjacking-css-protection to hidden.
Error goes away after patching per #5, RTBC!
Ran into this same issue upgrading from 9.5.11 to 10.3.1 (with Cohesion). Patch in #19 totally works. I'm not marking as RTBC bc this is probably an issue deep in Cohesion and it should probably be fixed there.
Any updates here on a potential fix/workaround?
Edited the description to include steps to repro!
OK β I created a branch against 2.x! Hopefully this gets us a plain diff for patching purposes but also this could be a pretty quick merge if a 2.x version can still be released. Unfortunately we're currently locked to 2.x bc of https://www.drupal.org/project/acquia_cms_common/issues/3427493 π Moderation dashboard version locked in project composer file Needs work
jds1 β changed the visibility of the branch 3221316-getting-required-contexts to active.
This is still an issue in 2.1.5, adding `required = FALSE` to the context definition fixes it. Trying to create an issue fork against 2.x so updating the version to see if that lets me do it :)
jds1 β changed the visibility of the branch 3221316-getting-required-contexts to hidden.
Thank you for this patch! I am looking for something like this too. The patch applies but the changes are still in `composer.lock` and we still end up in dependency hell. I think this would need to be committed for everything to apply, and I'm not sure if there are other implications about the `moderation_dashboard` dependency. This is something maintainers should chime in on.
RTBC!
RTBC!
RTBC!
RTBC!
Something else was wrong with my local. Everything works beautifully with patch applied. Merged and cutting a release momentarily. Thank you @NikolaAt!
Hi @NikolaAt! After patching I get a "Could not retrieve the oEmbed resource." whenever I try to embed a video. Are you able to successfully embed one?
I'm definitely running into these issues on D10 described by @NikolaAt β taking a look at the MR.
Hi @NikolaAt β if there is an issue related to VidyardResourceFetcher please create a new issue to track it.
The module is now D10 Compatible so we can mark this as fixed. Thanks all!
Something was up with that merge request but I got maintainer access and got this updated! I'm going to look at the other issue and see if I can cut a d10-compatible release for us this week. More soon!
Works great! RTBC. Thanks for this!
This is working for us!
This patch applies but we still cannot do a d10 upgrade because there is no d10-compatible release out yet. I messaged the maintainer about this last week and I want to give them a few more days to respond. Noting here for anyone trying to upgrade to D10 that you will be blocked until this module has a compatible release.
Here's a patch that also updates `composer.json` and the info.yml. I'm going to try and apply this to see if we can get a d10 upgrade going.
Hello! Thanks for all of your work on this module and d10 compatibility. Would it be possible to get a stable release cut of the 2.x branch so we don't have to point to a dev branch?
Thank you!
+1 to a release! It looks like the last dev branch update hasn't been since November 2022 so I'm going to message a maintainer and see if we can get something going.
Hey @mandclu β thank you so much for the quick follow-up today!! Much appreciated.
Hey @martijin β thanks for responding :)
For this particular site that's currently in production we need a png fallback because it is possible some constituents are using older browsers. Plus the delta of updating all image styles to use core webp is much greater than updating one module. I will, without a doubt, use core webp support on all new projects moving forward though. It's real exciting stuff!!
Thank you agoradesign for another +1 for a release!
I'm gonna give it another day before I start messaging some of the maintainers to see if we can move this along. That will mean we can close this issue too!
Wim Leers β credited jds1 β .
I know I commented about it last week but 11k+ sites still use this module and will continue to use it until the core issue is fixed. Can we please have a d10-compatible release ASAP? The patch applies but patching doesn't work and `composer info drupal/webp` is still showing `requires
drupal/core ^8 || ^9`. Are the maintainers active on this project/in the comments? This is blocking d10 upgrades.
Thank you in advance for your support!
Adjusted the patch in #20 so that it's D10 compatible/not flagged by Upgrade Status
Could we please have a d10-compatible release out soon so we don't have to patch? Thanks!
Somewhat related to #20 above, this patch combined with the patch in https://www.drupal.org/project/linkit/issues/2712951 β¨ Linkit for Link field Fixed does not allow for linking directly to files. I was about to post on 2712951 but then reinstalled without the patch from #13 β linking to files totally works now!
Thanks to everyone for your contributions here. So much amazing progress on this module already this year.
Rerolled #41 against 6.0.x https://git.drupalcode.org/project/linkit/-/merge_requests/16. Everything passes. Patch applies cleanly locally against both 6.0.x-dev and 6.0.0-beta4. Tested locally and now I'm getting aliases instead of node URLs! Marking as "Needs Review" β thank you!
jds1 β made their first commit to this issueβs fork.
+1 to a D10 release please!
Hi everyone! Apologies for the multiple MRs β I am still trying to figure out this new process vs. old skool patching =).
We have a client where the auto-scrolling behavior is causing massive usability problems in Layout Builder when combined with Layout Builder iFrame Modal. MR 3357 removes this in 9.5.x (tested) and MR 3355 removes this in 10.1.x (untested, probably should just let this one be but I will circle back once I get 10.x running). I know there are plans to replace this with something else at some point and I doubt this type of removal will be accepted, but honestly I believe the experience is much better without the auto scrolling.