- Issue created by @project update bot
- last update
8 months ago PHPLint Failed This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- last update
8 months ago PHPLint Failed - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
The class
Drupal\schemata_json_schema\Encoder\JsonSchemaEncoder
extends a core class (namelyDrupal\serialization\Encoder\JsonEncoder
) which is being marked as@internal
(meaning โThis encoder should not be used directly. Rather, use the `serializer` serviceโ). - last update
7 months ago PHPLint Failed - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ changed the visibility of the branch project-update-bot-only to hidden.
- Status changed to RTBC
7 months ago 9:57am 17 May 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Bot changes reviewed, scanned with Drupal Rector, installed & uninstalled on a D11-alpha1, MR#12 should be good to go.
- Status changed to Needs review
6 months ago 5:35pm 2 June 2024 - last update
6 months ago 8 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ these changes make this module compatible with Drupal 11! ๐
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188815These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
- last update
6 months ago 8 pass - last update
6 months ago PHPLint Failed - Status changed to Needs work
6 months ago 5:02pm 18 June 2024 - ๐บ๐ธUnited States japerry KVUO
The gitlab ci issue should be committed and tested before this gets committed. With the changes to return types its very unlikely this will work in Drupal 8, so the minmum version should be updated to Drupal 9.5.11
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Personally, I find the situation somewhat messy around this project rather than simply bumping the required core version by one.
๐ 1.0 release roadmap Active
First of all, it would clear the picture to hear from current maintainers about whether they can/will/plan to work towards a stable 1.0 release.#3258113: [META] Future of Schemata/Compatibility with other ecosystem modules โ
Reading about the concerns regarding the project's purpose might also correlate with the 1.0 roadmap.๐ PHP 8.2 compatibility RTBC
Committing PHP 8.2 compatibility would definitely pull the rug out from under Drupal 8 support, therefore I feel bumping the required core version is more suitable to do over there. Committed to that MR.๐ Add gitlab CI RTBC
And I agree that adding Gitlab CI support is also a necessity.Once these issues are resolved then we will be good to go for D11 compatibility safely.
- last update
5 months ago PHPLint Failed - First commit to issue fork.
- last update
5 months ago PHPLint Failed - last update
5 months ago PHPLint Failed - last update
5 months ago PHPLint Failed - ๐ฎ๐ณIndia ankitv18
@japerry Please check https://git.drupalcode.org/project/schemata/-/jobs/1954096#L56
I pushed those typehints as this module is having dependency on openapi_jsonapi.
Is there any alternative approach with D11.x compatibility for normalize and denormalize which I'm missing here? - Status changed to Postponed
5 months ago 5:53am 27 June 2024 - ๐บ๐ธUnited States japerry KVUO
Marking postponed so this doesn't get committed before the other json api modules. When https://www.drupal.org/project/jsonapi_extras/issues/3451984 ๐ Automated Drupal 11 compatibility fixes for jsonapi_extras Fixed gets resolved a new release made, we can mark the next version of schemata incompatible with earlier versions of jsonapi_extras, avoiding a potential WSOD due to syntax errors on a return type mismatch.
- Status changed to Needs work
5 months ago 6:03pm 27 June 2024 - ๐ฎ๐ณIndia ankitv18
This issue https://www.drupal.org/project/jsonapi_extras/issues/3451984 ๐ Automated Drupal 11 compatibility fixes for jsonapi_extras Fixed is merged now
We can proceed with the readiness of this module. - Status changed to Needs review
5 months ago 6:34pm 27 June 2024 - ๐ฎ๐ณIndia ankitv18
Fixed the pipelines and required issues related to D11.
cc: @japerry - ๐ฎ๐ณIndia vipin.mittal18 Greater Noida
Hello maintainers,
The release of a pre/dev version of schemata would be helpful to the maintainers of OpenAPI for JSON:API, since it is dependent on schemata. Thanks!
-
japerry โ
committed 3eec8b01 on 8.x-1.x authored by
Balu Ertl โ
Issue #3434339 by ankitv18, japerry, Balu Ertl: Automated Drupal 11...
-
japerry โ
committed 3eec8b01 on 8.x-1.x authored by
Balu Ertl โ
- Status changed to Fixed
4 months ago 5:02pm 23 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.