- Issue created by @piyush.sharma0985
- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
This is intended to cause a fatal error, that is what is being tested that Upgrade Status does not collapse on scanning a module with a PHP fatal error in it :) So not sure what you mean here? If we would comment out that line it would not cause the fatal error that we need.
- ๐บ๐ธUnited States mikemadison Seattle, WA
Hey Gabor, when I'm trying to run PHPStan and Drupal Check and other tools on my contrib modules, they are all erring out on this specific test. I think your "fatal error" test is working a bit too well, unfortunately.
Not sure what we need to do to allow your fatal error testing to work, but what you're doing now is making a bunch of other automated scanning tools impossible in CI.
- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
@mikemadison: For example with PHPStan, you can ignore errors or whole files and directories: https://phpstan.org/user-guide/ignoring-errors#excluding-whole-files, so you would run your tool in CI with configuration that ignores the test files of Upgrade Status. (You would probably want to ignore tests of contributed and core modules in general to speed up your CI, even if you want to keep checking tests of your own custom modules).