- Issue created by @catch
- 🇬🇧United Kingdom catch
None of this is Umami specific so moving it to install system.
- 🇺🇸United States phenaproxima Massachusetts
Recipe Installer Kit deals with this by wrapping the messenger service with an implementation of MessengerInterface that can store a list of (untranslated) messages to ignore. Profiles built on Recipe Installer Kit can list those messages in their info file.
https://git.drupalcode.org/project/recipe_installer_kit/-/blob/1.x/src/H...
Maybe a similar approach for core?
- 🇬🇧United Kingdom catch
At first I was thinking of doing this by trying to detect when we're running in the installer, but now I'm wondering where we ever actually need those messages in the UI at all? If we install translations in a batch, this information is broadly communicated anyway, so maybe we can log instead?
- 🇺🇸United States phenaproxima Massachusetts
I like it. Pretty simple change too. It would need to happen in Locale, which is where the message is set.
- 🇬🇧United Kingdom catch
I hadn't looked where these are set yet and didn't realise we already log, and that these are only set on the batch - given batch progress shows this really feels fine. Just a couple of tests to update it looks like.
- 🇬🇧United Kingdom catch
MR looks pretty good to me, we're just removing the doubling up of the message and the log message.
I think we should also drop "check available translations for your languages" but that could be done in its own issue.
- 🇫🇮Finland lauriii Finland
+1 for removing these messages including the "check available translations for your languages".
- 🇬🇧United Kingdom catch
Opened 📌 Remove the 'Check available translations for your languages' from locale_install() Active for the check available translations message which is set from locale_install() rather than the batch handling.
- 🇭🇺Hungary Gábor Hojtsy Hungary
Can we somehow add back the feedback when an individual user action (eg. running translation updates or importing .po file) is done? I think with this MR if you do a manual action that affects your translations, you may not be getting any feedback?
I do agree the same feedback in the installer is useless, superfluous and distracting :)
- 🇺🇸United States smustgrave
Just confirmed on Umami that when I installed a new module I didn't get the message
The configuration was successfully updated. There are 212 configuration objects updated.