Fix ToolkitGdTest n PHP 8.5

✘ Manipulations with 29 ┐ ├ Image 'image-test.gif' object after 'rotate_5' action has the correct color placement at corner '0' - Actual: {255,0,93,0}, Expected: {255,0,255,0}, Distance: 26244, Tolerance: 0 ├ Failed asserting that 26244 is equal to 0 or is less than 0. │ │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90 │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357 ┴ ✘ Manipulations with 30 ┐ ├ Image 'image-test.gif' object after 'rotate_transparent_5' action has the correct color placement at corner '0' - Actual: {255,93,0,46}, Expected: {255,255,255,127}, Distance: 97830, Tolerance: 0 ├ Failed asserting that 97830 is equal to 0 or is less than 0. │ │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90 │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357 ┴

Comments & Activities

Issue created by @andypost
Comment 13 days ago →
🇫🇷France andypost
Comment 6 days ago →
🇫🇷France andypost
First commit to issue fork.
Merge request !13006[#3540531] fix: Fix ToolkitGdTest for PHP 8.5 → (Open) created by Taran2L
Merge request !13007Draft: Resolve #3540531 "Test ToolkitGdTest on php 85" → (Open) created by andypost
Comment 6 days ago →
🇫🇷France andypost
Created testing branch with patches to run tests on 8.5 from 📌 Discus adoption of #NoDiscard and PHP 8.5 Active
Pipeline finished with Canceled
6 days ago
Total: 1466s
#573954
Pipeline finished with Failed
6 days ago
Total: 756s
#573964
Pipeline finished with Success
6 days ago
Total: 635s
#573967
Comment 6 days ago →
🇺🇦Ukraine Taran2L Lviv
So, my idea was to recreate the file itself (maybe it has encoding issues), but that didn't work ...
Pipeline finished with Failed
6 days ago
Total: 703s
#573992
Comment 6 days ago →
🇫🇷France andypost
Thank you, looks like good idea but I think the rotation got changes(
Comment 6 days ago →
🇫🇷France andypost
Comment 6 days ago →
🇺🇦Ukraine Taran2L Lviv
Seems like rotation is affected either by our code or by how PHP8.5 handles it, as all rotate to 5 degrees tests are broken (file format is not relevant, it happens for all of them)

See https://git.drupalcode.org/issue/drupal-3540531/-/jobs/6225263#L2188

The other part is AVIF, I assume Docker image does not have AVIF support at all (or it's broken in PHP itself)
Comment 6 days ago →
🇺🇦Ukraine Taran2L Lviv
So, it seems that the default interpolation algorithm has been changed, see https://github.com/php/php-src/pull/17375/files#diff-a6d1ba8e66261eacec5...

That probably means that we need to adjust test to that
Comment 6 days ago →
🇺🇦Ukraine Taran2L Lviv
taran2l → changed the visibility of the branch 3540531-fix-toolkitgdtest-for to hidden.
Comment 6 days ago →
🇫🇷France andypost
IIRC we fixed AVIF long time ago by using Ubuntu as a source for CI images
Pipeline finished with Failed
3 days ago
Total: 655s
#575716

Fix ToolkitGdTest n PHP 8.5

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Merge Requests

!13007Fix ToolkitGdTest n PHP 8.5
Open

!13006Fix ToolkitGdTest n PHP 8.5
Open

Comments & Activities

Fix ToolkitGdTest n PHP 8.5

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Merge Requests

!13007Fix ToolkitGdTest n PHP 8.5Open

!13006Fix ToolkitGdTest n PHP 8.5Open

Comments & Activities

!13007Fix ToolkitGdTest n PHP 8.5
Open

!13006Fix ToolkitGdTest n PHP 8.5
Open